HBHE: add photostatitics uncertainty in the M2 #17533

mariadalfonso · 2017-02-16T10:50:44Z

This PR is a follow up on the #17311
And make use of the new GT #17530

The noise uncertainty now is added in the M2 chi2 also for the HPD.
validation slides are here
http://dalfonso.web.cern.ch/dalfonso/PhotoStatHPD.pdf

�

cmsbuild · 2017-02-16T10:51:05Z

A new Pull Request was created by @mariadalfonso for CMSSW_9_0_X.

It involves the following packages:

Configuration/AlCa
RecoLocalCalo/HcalRecAlgos

@ghellwig, @cvuosalo, @arunhep, @cerminar, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @tocheng, @argiro this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

slava77 · 2017-02-16T12:22:00Z

@cmsbuild please test

there appear to be run time issues with #17530
Also, #17530 GT updates geometry in 2017, which makes this PR change incrementally untestable.

So, this PR may not move until #17530 is merged.

cmsbuild · 2017-02-16T12:23:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17814/console Started: 2017/02/16 13:31

cmsbuild · 2017-02-16T14:09:22Z

-1

Tested at: 2dae29d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17533/17814/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_8TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Thu Feb 16 14:52:48 2017-date Thu Feb 16 14:48:35 2017 s - exit: 34304
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-02-15-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Feb 16 14:52:48 2017-date Thu Feb 16 14:48:35 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Thu Feb 16 14:52:48 2017-date Thu Feb 16 14:48:35 2017 s - exit: 21504

cmsbuild · 2017-02-16T14:09:24Z

Comparison job queued.

cmsbuild · 2017-02-16T17:37:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17533/17814/summary.html

franzoni · 2017-02-16T18:33:07Z

Alca signature subject to resolution of #17530
Where investigations are on going re content of payloads

abdoulline · 2017-02-17T06:14:52Z

I've fixed the content of HcalSiPMParameters for Run 1, Walter will submit a new tag (HcalSiPMParameters_v1.2_mc) today. Plus two data ones with updated Run 1 IOVs.
Sorry about this Run 1 conditions mistake, which slows down the pace of updates...

slava77 · 2017-02-17T15:09:13Z

RecoLocalCalo/HcalRecAlgos/src/PulseShapeFitOOTPileupCorrection.cc

-
-      noisePHArr[ip] = sqrt((charge-ped)*0.3305);
+    if(!channelData.hasTimeInfo() && (charge-ped)>noise_) {
+      noisePHArr[ip] = sqrt((charge-ped)*channelData.fcByPE());


is the value here consistent with 0.3305 used in PulseShapeFitOOTPileupCorrection::apply?
I was actually expecting that the same source is used in all cases.

with the new GT, for HPD, printing on the screen the channelData.fcByPE() is 0.3305

Nice, thank you for the confirmation.
Can we avoid the hardcoded value in the PulseShapeFitOOTPileupCorrection::apply and get it from DB?

the amazing class HBHEChannelInfo channelData.fcByPE() is only available for the Phase1Code.

For the run1/run2 code I will likely have to do a lot of gymnastic.
I tried to do this in the past unsuccessfully for the other parameters i.e. the noise mariadalfonso@c923f24
The old M2 code is anyway full of all hard coded numbers so one more or less should not make a big difference. I can see if I can find an easy way, but no promises (maybe we can put in the post-pre5 SW rework)?

@igv4321 please clarify what is the status of moving all of the hbhe reco to the phase-1 code?

We are working on it. Approximate time line when it happens is end of Feb. @halilg might be able to provide more details.

slava77 · 2017-02-17T19:58:29Z

On 2/17/17 11:54 AM, mariadalfonso wrote: (maybe we can put in the post-pre5 SW rework)?

yes, OK.

slava77 · 2017-02-19T08:32:19Z

there is a merge conflict here now

cmsbuild · 2017-02-19T17:07:44Z

Pull request #17533 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

mariadalfonso · 2017-02-19T17:08:42Z

@slava77
rebased on top of CMSSW_9_0_X_2017-02-19-1100

slava77 · 2017-02-19T17:09:21Z

@cmsbuild please test

cmsbuild · 2017-02-19T17:09:38Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17871/console Started: 2017/02/19 20:39

slava77 · 2017-02-19T20:16:15Z

[the following is based on https://github.com//pull/17533 2dae29d; made in CMSSW_9_0_X_2017-02-16-1100 as a baseline; I made a quick check with the later version to confirm that the conclusions do not change]

The main change from this PR is improved chi2 in hbhe hits
10224:
barrel

endcap

There is also a significant reduction (by x2 in the barrel) in the number of hits with the 3-pulse fit flag (HBHEPulseFitBit=29)

The fraction of non-zero (E>1 MeV) hits is up in the PU sample:
by 7% in the barrel

and by 13% in the endcaps

Since the 1-pulse fit is tried first, we should expect more OOT PU energy to come in for the fraction of previously 3-pulse fitted hits, which OTOH also had a fraction of in-time energy "eaten" by the OOT component.

The number of neutral hadrons is up by 12%

This transfers to probably 1-2% increase in lower-pt jet response

Jet samples without pileup show smaller differences in response, with sub-% increase in the TeV range.
Time of rechits is more flat now [wf 10071 flat-pt QCD sample]

chi2 is smaller, as expected

In data, changes look fairly similar to ttbar MC with PU
e.g. in 2016E JetHT (136.761)
chi2 in endcap

hit energy E>1MeV in endcap

On the technical side, in PU35 ttbar (wf10224)

the hbheprereco time is down by 24% (or about 1% of total reco time)
given the increase in the number of hits with E>0 some module times are up:
- particleFlowClusterHBHE up by 50% (from 7 to 11 ms/evt)
- particleFlowClusterHCAL up by 15% (negligible for the total; under 2ms/evt)

Overall, this seems ready to sign; I'll wait for jenkins tests to finish.

cmsbuild · 2017-02-19T20:50:40Z

+1
Tested at: fd3b827
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17533/17871/summary.html

cmsbuild · 2017-02-19T20:50:42Z

Comparison job queued.

cmsbuild · 2017-02-19T22:40:12Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17533/17871/summary.html

slava77 · 2017-02-19T23:32:40Z

+1

for #17533 fd3b827

changes are as described: to add the photostatistics component to the error used in hit fit minimization in M2; affects all simulations with HPDs
jenkins tests pass and comparisons with baseline show differences that start from hbhe hit reco and propagate downstream; differences are consistent with what's found in the local tests summarized in HBHE: add photostatitics uncertainty in the M2 #17533 (comment)
- the tests after rebase also do not show any irrelevant differences as present earlier in the comparisons due to the GT changes that were included with this PR

cmsbuild · 2017-02-19T23:33:54Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-02-20T08:48:52Z

+1

cmsbuild added this to the Next CMSSW_9_0_X milestone Feb 16, 2017

cmsbuild added alca-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Feb 16, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 16, 2017

cmsbuild added tests-rejected and removed tests-started labels Feb 16, 2017

cmsbuild added comparison-available and removed comparison-pending labels Feb 16, 2017

slava77 reviewed Feb 17, 2017

View reviewed changes

franzoni mentioned this pull request Feb 18, 2017

HCAL SiPMParameters, geometry 2017/2018, tracking MVA 2017/2018 #17530

Merged

mariadalfonso force-pushed the HPDphStat branch from 2dae29d to 2c5e5a3 Compare February 19, 2017 08:50

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels Feb 19, 2017

add photonStat unc in the HPD

fd3b827

mariadalfonso force-pushed the HPDphStat branch from 2c5e5a3 to fd3b827 Compare February 19, 2017 17:07

cmsbuild added tests-pending and removed alca-pending tests-approved labels Feb 19, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 19, 2017

cmsbuild added tests-approved and removed tests-started labels Feb 19, 2017

cmsbuild added comparison-available and removed comparison-pending labels Feb 19, 2017

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Feb 19, 2017

cmsbuild added orp-approved and removed orp-pending labels Feb 20, 2017

cmsbuild merged commit b85c807 into cms-sw:CMSSW_9_0_X Feb 20, 2017

mariadalfonso mentioned this pull request Mar 21, 2017

HBHE M3 = fix M3 (90) #17984

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBHE: add photostatitics uncertainty in the M2 #17533

HBHE: add photostatitics uncertainty in the M2 #17533

mariadalfonso commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

slava77 commented Feb 16, 2017

cmsbuild commented Feb 16, 2017 •

edited

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

franzoni commented Feb 16, 2017

abdoulline commented Feb 17, 2017 •

edited

slava77 Feb 17, 2017

mariadalfonso Feb 17, 2017

slava77 Feb 17, 2017

mariadalfonso Feb 17, 2017

slava77 Feb 19, 2017

igv4321 Feb 19, 2017

slava77 commented Feb 17, 2017 via email

slava77 commented Feb 19, 2017

cmsbuild commented Feb 19, 2017

mariadalfonso commented Feb 19, 2017

slava77 commented Feb 19, 2017

cmsbuild commented Feb 19, 2017 •

edited

slava77 commented Feb 19, 2017 •

edited

cmsbuild commented Feb 19, 2017

cmsbuild commented Feb 19, 2017

cmsbuild commented Feb 19, 2017

slava77 commented Feb 19, 2017

cmsbuild commented Feb 19, 2017

davidlange6 commented Feb 20, 2017

HBHE: add photostatitics uncertainty in the M2 #17533

HBHE: add photostatitics uncertainty in the M2 #17533

Conversation

mariadalfonso commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

slava77 commented Feb 16, 2017

cmsbuild commented Feb 16, 2017 • edited

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

franzoni commented Feb 16, 2017

abdoulline commented Feb 17, 2017 • edited

slava77 Feb 17, 2017

Choose a reason for hiding this comment

mariadalfonso Feb 17, 2017

Choose a reason for hiding this comment

slava77 Feb 17, 2017

Choose a reason for hiding this comment

mariadalfonso Feb 17, 2017

Choose a reason for hiding this comment

slava77 Feb 19, 2017

Choose a reason for hiding this comment

igv4321 Feb 19, 2017

Choose a reason for hiding this comment

slava77 commented Feb 17, 2017 via email

slava77 commented Feb 19, 2017

cmsbuild commented Feb 19, 2017

mariadalfonso commented Feb 19, 2017

slava77 commented Feb 19, 2017

cmsbuild commented Feb 19, 2017 • edited

slava77 commented Feb 19, 2017 • edited

cmsbuild commented Feb 19, 2017

cmsbuild commented Feb 19, 2017

cmsbuild commented Feb 19, 2017

slava77 commented Feb 19, 2017

cmsbuild commented Feb 19, 2017

davidlange6 commented Feb 20, 2017

cmsbuild commented Feb 16, 2017 •

edited

abdoulline commented Feb 17, 2017 •

edited

cmsbuild commented Feb 19, 2017 •

edited

slava77 commented Feb 19, 2017 •

edited