Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PFClusterProducer For ConfDB #1754

Merged

Conversation

Martin-Grunewald
Copy link
Contributor

ConfDB uses static templates with always all parameters. Hence a plugin should not behave differently if a
parameter is present in the py config or not. This fix replaces that logic by checking the value of the added
InputTag: if it is empty, the old behaviour (as was without this parameter present) is obtained.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_0_X.

Fix PFClusterProducer For ConfDB

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

@thspeer
Copy link
Contributor

thspeer commented Dec 11, 2013

Working @thspeer

@thspeer
Copy link
Contributor

thspeer commented Dec 11, 2013

+1
tested 12c35bd in CMSSW_7_0_X_2013-12-11-0200-1754
no difference on reco as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 12, 2013
…rConfDB

HLT -- Fix PFClusterProducer For ConfDB
@ktf ktf merged commit 10ad302 into cms-sw:CMSSW_7_0_X Dec 12, 2013
@Martin-Grunewald Martin-Grunewald deleted the FixPFClusterProducerForConfDB branch December 13, 2013 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants