Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCAL TP for Plan 1 #17540

Merged
merged 9 commits into from Feb 20, 2017
Merged

HCAL TP for Plan 1 #17540

merged 9 commits into from Feb 20, 2017

Commits on Feb 16, 2017

  1. Add more trigger geometry modes for Plan1 and Phase2.

    @matz-e
    matz-e committed Feb 16, 2017
    Copy the full SHA
    f78d3dd View commit details
    Browse the repository at this point in the history

  2. Fix 2017 trigger mode to use QIE10 in HF.

    @matz-e
    matz-e committed Feb 16, 2017
    Copy the full SHA
    6f55472 View commit details
    Browse the repository at this point in the history

  3. Simplify branches for HT validity.

    @matz-e
    matz-e committed Feb 16, 2017
    Copy the full SHA
    19551e7 View commit details
    Browse the repository at this point in the history

  4. Fix branch.

    @matz-e
    matz-e committed Feb 16, 2017
    Copy the full SHA
    ee0a5cb View commit details
    Browse the repository at this point in the history

  5. Increase robustness of HCAL TP LUT generation. 

    The current code crashes for Phase2.  Instead of generating all possible
DetIds and testing which ones are allowed, it is a lot cleaner to just
iterate over the produced metadata ids.
    @matz-e
    matz-e committed Feb 16, 2017
    Copy the full SHA
    d1f3901 View commit details
    Browse the repository at this point in the history

  6. Filter out invalid ids.

    @matz-e
    matz-e committed Feb 16, 2017
    Copy the full SHA
    3a24747 View commit details
    Browse the repository at this point in the history

  7. Add Plan1 glue for HCAL TP.

    @matz-e
    matz-e committed Feb 16, 2017
    Copy the full SHA
    c8d7213 View commit details
    Browse the repository at this point in the history

  8. Fix the values of the trigger modes to match the ones already in the DB.

    @matz-e
    matz-e committed Feb 16, 2017
    Copy the full SHA
    9c7c69d View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2017

  1. Keep messy special statements at bay. 

    This makes the old 2017, now 2018 trigger mode value (2) a special "legacy"
item, and keeps the new trigger modes consistent above that in the enum.
Allows to keep comparisons in the code as long as the legacy value is
accounted for.
    @matz-e
    matz-e committed Feb 17, 2017
    Copy the full SHA
    fe19e4f View commit details
    Browse the repository at this point in the history