Ecal laser alphas

[depasse]

Replace PR Ecal laser alphas (#17234)
Laser alpha now Xtal by Xtal from a txt file (before, only a mean for Russian/Chinese Xtals).

Please test with cms-sw/cmsdist#2831 cms-bot command

[cmsbuild]

A new Pull Request was created by @depasse for CMSSW_9_0_X.

It involves the following packages:

CalibCalorimetry/EcalTrivialCondModules
CondTools/Ecal

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @tocheng, @argiro this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test with cms-sw/cmsdist#2831

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2831
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17844/console

[cmsbuild]

-1

Tested at: ce830c8

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17546/17844/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test TestFWCorePythonFrameworkDriver had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17546/17844/summary.html

[depasse]

Pb with FileInPath :

When I want to test the "fromFile" version (the byType works) :

$ cmsRun create_alpha_trivial_fromFILE.py
----- Begin Fatal Exception 18-Feb-2017 09:09:20 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
[0] Processing the python configuration file named create_alpha_trivial_fromFILE.py
Exception Message:
python encountered the error: <type 'exceptions.RuntimeError'>
edm::FileInPath unable to find file CalibCalorimetry/EcalTrivialCondModules/data/EBLaserAlpha_fromFile.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /afs/cern.ch/work/d/depasse/cmssw/CMSSW_9_0_0_pre4/src:/afs/cern.ch/work/d/depasse/cmssw/CMSSW_9_0_0_pre4/external/slc6_amd64_gcc530/data:/cvmfs/cms.cern.ch/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_0_pre4/src:/cvmfs/cms.cern.ch/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_0_pre4/external/slc6_amd64_gcc530/data
Current directory is: /afs/cern.ch/work/d/depasse/cmssw/CMSSW_9_0_0_pre4/src/CondTools/Ecal/test/alpha

----- End Fatal Exception -------------------------------------------------

What must I add/do ? Thanks.

[ghellwig]

please test

[ghellwig]

to refresh the test results

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19001/console Started: 2017/04/07 15:11

[cmsbuild]

+1
Tested at: 2ebcb49
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17546/19001/summary.html

[cmsbuild]

Comparison job queued.

[franzoni]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17546/19001/summary.html

Comparison Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1915960
• DQMHistoTests: Total failures: 29900
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1885887
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[franzoni]

hello @depasse
the equivalent of this PR has been merged in 91x in #17719
91x is about to close and be deployed in production

is this PR targeting 90x still of need ? In which case, can you give us the rational.
If not, would you consider closing it.

Thanks!