Keeping the z ordering in the NavigationSchool sorting and fix analyzer

[ebrondol]

• The sorting process need to keep the order in z otherwise the if condition afterwards can also not be satisfied as it should. The stable_sort has been also propagated to the other sorting processes.
• The bug in the analyzer was is caused by the PR RecoTracker test classes: fix clang warnings #16993. Thanks to @makortel to spot the issue!

[cmsbuild]

A new Pull Request was created by @ebrondol for CMSSW_9_0_X.

It involves the following packages:

RecoTracker/TkNavigation

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[VinInn]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17840/console Started: 2017/02/17 14:29

[slava77]

On 2/17/17 5:25 AM, ebrondol wrote: * The sorting process need to keep the order in z otherwise the |if| condition afterwards can also not be satisfied as it should. The |stable_sort| has been also propagated to the other sorting processes. * The bug in the analyzer was is caused by the PR #16993 <#16993>. Thanks to @makortel <https://github.com/makortel> to spot the issue!

is #16993 a correct PR for the reference? Do we expect any changes in performance? If so, please post MTV plots

[makortel]

@slava77

is #16993 a correct PR for the reference?

Yes. The signature of beginRun() was changed such that the function gets actually executed, and there tTopo was not initialized before use.

[cmsbuild]

+1
Tested at: 73f49c2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17547/17840/summary.html

[cmsbuild]

Comparison job queued.

[ebrondol]

@slava77 no changes are expected.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17547/17840/summary.html

[slava77]

+1

for #17547 73f49c2

• technical change as described
• jenkins tests pass and comparisons with baseline show no difference

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1