bsunanda:Run2-hcx108 Effect of Plan1 geometry on Calibration #17550
Conversation
|
A new Pull Request was created by @bsunanda for CMSSW_9_0_X. It involves the following packages: Calibration/HcalCalibAlgos @ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
@bsunanda , in the last file of this PR you have: for (unsigned int k=0; k<8; ++k) { |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #17550 was updated. @ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @mmusich, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Pull request #17550 was updated. @ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @mmusich, @davidlange6 can you please check and sign again. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
@ianna I hope I explained the issues |
|
Comparison job queued. |
|
+1 |
|
unhold |
|
@franzoni @davidlange6 Please approve - need at least 2 more PR's after this to make Plan1 operational |
| CaloCellGeometry::CornersVec mcorners; | ||
| CaloCellGeometry::CornersVec mcf = getGeometry(ids.front())->getCorners(); | ||
| CaloCellGeometry::CornersVec mcb = getGeometry(ids.back())->getCorners(); | ||
| for (unsigned int k=0; k<4; ++k) { |
There was a problem hiding this comment.
hello @bsunanda
can you guarantee (or do you need to check)
that mcf/mcb have at least , resp. , 4 and 8 elements ?
There was a problem hiding this comment.
All CaloCellGeometry defines a cornersvec with 8 elements. This is the definition of CaloCellGeometry::CornersVec. It does not need a further check to the best of my understanding
|
+1 In light of:
|
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
Provide a few functions : getPosition, getCorners to HcalGeometry which can handle merged DetId's in addition to CaloCellGeometry functionalities. It does not affect any earlier functionalities