Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap TrackSelectors in tracking DQM to cms.ignore #17582

Merged
merged 1 commit into from Feb 21, 2017
Merged

Wrap TrackSelectors in tracking DQM to cms.ignore #17582

merged 1 commit into from Feb 21, 2017

Conversation

makortel
Copy link
Contributor

To silence warnings on ignored EDFilter return values, along #17576.

IMHO a more proper solution would be to transform TrackSelector to an EDProducer, and move the whole tracking DQM from EndPath to Path (as, IIUC, nothing there depends on the TriggerResults of the current process), but that would need more effort.

Tested in CMSSW_9_0_X_2017-02-19-1100, no changes expected.

@rovere @VinInn @mtosi

@makortel
Silence warnings on ignored EDFilter return values
8732900 
More proper solution would be to transform TrackSelector to an
EDProducer, and move whole tracking DQM from EndPath to Path (as
nothing depends on the TriggerResults of the current process, right?).
@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Feb 20, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17895/console Started: 2017/02/21 09:49

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X.

It involves the following packages:

DQM/TrackingMonitorSource

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @mtosi, @fioriNTU, @threus, @hdelanno this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@makortel makortel mentioned this pull request Feb 20, 2017
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: 8732900
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17582/17895/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@davidlange6 davidlange6 mentioned this pull request Feb 21, 2017
Closed
@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 613e56d into cms-sw:CMSSW_9_0_X Feb 21, 2017
@davidlange6 davidlange6 mentioned this pull request Feb 21, 2017
Merged
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17582/17895/summary.html

@makortel makortel deleted the silenceTrackSelector branch February 12, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makortel @cmsbuild @dmitrijus @davidlange6