Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SiStripDQM : number of cluster trend in wheel/layer, number of cluster per ring and per layer #17592

Merged
merged 1 commit into from Apr 5, 2017
Merged

SiStripDQM : number of cluster trend in wheel/layer, number of cluster per ring and per layer #17592

merged 1 commit into from Apr 5, 2017

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Feb 21, 2017

Implementation of several plots in SiStripMonitorCluster package: number of cluster trend in wheel/layer, number of cluster per ring and per layer. Change in apv charge median plot switch in SiStripMonitorDigi package

Backport of the same code from the already merged PR in 90X : #17304

Would be great to have for the legacy Re-reco

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Feb 21, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_8_0_X.

It involves the following packages:

DQM/SiStripMonitorCluster
DQM/SiStripMonitorDigi

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@boudoul boudoul mentioned this pull request Feb 21, 2017
Closed
@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17920/console Started: 2017/02/22 15:49
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17924/console Started: 2017/02/22 19:32
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17930/console Started: 2017/02/23 03:01
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17934/console Started: 2017/02/23 12:40

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@dmitrijus
Copy link
Contributor

backport #17304

@cmsbuild
Copy link
Contributor

+1
Tested at: ac5206e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17592/17934/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17592/17934/summary.html

@boudoul
Copy link
Contributor Author

boudoul commented Feb 28, 2017

@dmitrijus , please add this PR in the dedicated list requested by the ORP for the rereco

@boudoul boudoul mentioned this pull request Feb 28, 2017
Closed
@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8d4ecd4 into cms-sw:CMSSW_8_0_X Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@boudoul @cmsbuild @dmitrijus @davidlange6