Consumes Interface for Muons I

[bachtis]

Hi,
Here are the changes on the consumes migrations for muons.

After running the reco again I see that I have a couple of dependencies left

• The RecoMuon/GlobalTrackingTools package -> will be finished by the end of the week
• Seems there are some Helpers in MuonIdProducer that are using Tracker modules
  that are not migrated. I guess I cannot do anything for those .

Question: In the Message Logger if there is an issue on the helper it is printed as an issue on the producer
right?
Michalis

[cmsbuild]

A new Pull Request was created by @bachtis for CMSSW_7_0_X.

Consumes Interface for Muons I

It involves the following packages:

RecoMuon/StandAloneTrackFinder
RecoMuon/MuonSeedGenerator
RecoMET/METProducers
RecoMuon/TrackerSeedGenerator
RecoMuon/L3MuonIsolationProducer
RecoMuon/L3TrackFinder
RecoMuon/MuonIsolation
RecoMuon/L2MuonSeedGenerator
RecoMuon/MuonIdentification
RecoMuon/TrackingTools
RecoMuon/GlobalTrackFinder
RecoMuon/StandAloneMuonProducer
RecoMuon/MeasurementDet
RecoMuon/L2MuonProducer
RecoMuon/MuonIsolationProducers
RecoMuon/CosmicMuonProducer
RecoMuon/L3MuonProducer
RecoMuon/GlobalMuonProducer

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[cmsbuild]

-1
I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/DQMOffline/JetMET/src/ECALRecHitAnalyzer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/DQMOffline/JetMET/src/HCALRecHitAnalyzer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/DQMOffline/JetMET/src/HTMHTAnalyzer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/DQMOffline/JetMET/src/JPTJetAnalyzer.cc 
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/DQMOffline/JetMET/src/BeamHaloAnalyzer.cc: In constructor 'BeamHaloAnalyzer::BeamHaloAnalyzer(const edm::ParameterSet&)':
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/DQMOffline/JetMET/src/BeamHaloAnalyzer.cc:72:66: error: no matching function for call to 'MuonSegmentMatcher::MuonSegmentMatcher(edm::ParameterSet&, MuonServiceProxy*&)'
   TheMatcher = new MuonSegmentMatcher(matchParameters, TheService);
                                                                  ^
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/DQMOffline/JetMET/src/BeamHaloAnalyzer.cc:72:66: note: candidates are:
In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/DQMOffline/JetMET/interface/BeamHaloAnalyzer.h:118:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/DQMOffline/JetMET/src/BeamHaloAnalyzer.cc:1:


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1760/1700/summary.html

[cmsbuild]

Pull request #1760 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @thspeer, @deguio, @slava77, @eliasron can you please check and sign again.

[cmsbuild]

-1
I found an error when building:

In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-11-0200/src/FWCore/Framework/src/Factory.h:4:0,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-11-0200/src/FWCore/Framework/interface/MakerMacros.h:4,
                 from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/FastSimulation/Muons/plugins/SealModules.cc:1:
/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-11-0200/src/FWCore/PluginManager/interface/PluginFactory.h: In instantiation of 'R\* edmplugin::PluginFactory::PMaker::create(Args ...) const [with TPlug = FastTSGFromIOHit; R = TrackerSeedGenerator; Args = {const edm::ParameterSet&, edm::ConsumesCollector&}]':
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/FastSimulation/Muons/plugins/SealModules.cc:10:85:   required from here
/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-11-0200/src/FWCore/PluginManager/interface/PluginFactory.h:51:55: error: no matching function for call to 'FastTSGFromIOHit::FastTSGFromIOHit(const edm::ParameterSet&, edm::ConsumesCollector&)'
           return new TPlug(std::forward(args)...);
                                                       ^
/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_X_2013-12-11-0200/src/FWCore/PluginManager/interface/PluginFactory.h:51:55: note: candidates are:
In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/FastSimulation/Muons/plugins/SealModules.cc:4:0:
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-12-11-0200/src/FastSimulation/Muons/plugins/FastTSGFromIOHit.h:27:3: note: FastTSGFromIOHit::FastTSGFromIOHit(const edm::ParameterSet&)


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1760/1717/summary.html

[Dr15Jones]

Question: In the Message Logger if there is an issue on the helper it is printed as an issue on the producer
right?
Yes

[cmsbuild]

Pull request #1760 was updated. @thspeer, @deguio, @lveldere, @danduggan, @rovere, @cmsbuild, @nclopezo, @giamman, @slava77, @eliasron can you please check and sign again.

[thspeer]

You can get the label by

edm::EDConsumerBase::Labels label;
labelsForToken(token,label);

So the next lines could be
edm::EDConsumerBase::Labels label1, label2;
labelsForToken((_iLink).first,label1);
labelsForToken((_iLink).second,label2);

std::string mapname = string(label1.productInstance) + "To" + string(label2.productInstance);

But no need to change, looks fine like that.

[cmsbuild]

Pull request #1760 was updated. @thspeer, @deguio, @lveldere, @danduggan, @rovere, @cmsbuild, @anton-a, @nclopezo, @giamman, @slava77, @eliasron can you please check and sign again.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1760/1787/summary.html

[thspeer]

+1
tested 141561b in CMSSW_7_0_X_2013-12-16-0200_1760
No difference in reco as expected, based on RelMon and reco script

[deguio]

+1

[ktf]

@lveldere I'll skip your signature since you seemed happy also without the changes requested by @thspeer. Complain if not the case.