bsunanda:Run2-TB22 Preparation for 2017 HGCal TB simulation #17606
Conversation
|
A new Pull Request was created by @bsunanda for CMSSW_9_0_X. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
| edm::LogInfo("HGCalGeom") << "DDHGCalWaferAlgo debug: Parent " | ||
| << parentName << " NameSpace " << idNameSpace | ||
| << " for Rotation " << rotns; | ||
| std::cout << "DDHGCalWaferAlgo debug: Parent " << parentName << " NameSpace " |
There was a problem hiding this comment.
@bsunanda - the code would benefit from replacing std::cout with
LogDebug("DDHGCalWaferAlgo") << ...
it will allow also to remove the lines:
#ifdef EDM_ML_DEBUG
...
#endif
|
+1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
So far we have some one module 28 wafer version of EE and 7 modules of 12 wafer version of FH. This as well as absorber structure may be modified once this is well known