Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching BoostedDoubleSV tagger to v4 training for AK8 jets (80X) #17609

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Feb 22, 2017

80X backport of #17294 for legacy 80X re-MiniAOD.

@cvernier

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_8_0_X.

It involves the following packages:

RecoBTag/SecondaryVertex

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 22, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17925/console Started: 2017/02/22 19:39

@slava77
Copy link
Contributor

slava77 commented Feb 22, 2017

@ferencek are the files in 80X already?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ferencek
Copy link
Contributor Author

@slava77, yes, the v4 training file is already in 80X (see cms-sw/cmsdist#2793).

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 27, 2017

+1

for #17609 caf4b54

  • change from V3 to V4 in input training file; affects double boosted tagging variable in slimmedJetsAK8 in miniAOD
  • jenkins tests pass and comparisons with baseline show no differences (the relevant variable is not monitored)

I'm going to put this on hold until the rereco release is to be built.
To go with #17603

@slava77
Copy link
Contributor

slava77 commented Feb 27, 2017

hold

until rereco release is to be built

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @slava77
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@davidlange6 davidlange6 merged commit cfbc028 into cms-sw:CMSSW_8_0_X Apr 5, 2017
@ferencek ferencek deleted the BoostedDoubleSVTaggerV4-PR_from-CMSSW_8_0_21 branch April 5, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants