Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-hcx113 Bug fix for Plan 1 Geometry #17613

Merged
merged 1 commit into from Feb 23, 2017

Conversation

bsunanda
Copy link
Contributor

2 issues addressed: maximum layer # for a given depth and wrongly initialized variable - both for plan 1 application

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Feb 22, 2017
@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17933/console Started: 2017/02/23 06:06
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17936/console Started: 2017/02/23 12:42

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_9_0_X.

It involves the following packages:

Geometry/HcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@davidlange6 davidlange6 merged commit b882815 into cms-sw:CMSSW_9_0_X Feb 23, 2017
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ianna
Copy link
Contributor

ianna commented Feb 23, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@ianna
Copy link
Contributor

ianna commented Feb 23, 2017

+1

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants