Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing work in progress #17652

Merged
merged 1 commit into from Mar 1, 2017
Merged

Conversation

ebrondol
Copy link
Contributor

As requested and discussed in #17594.

@kpedro88

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ebrondol for CMSSW_9_0_X.

It involves the following packages:

RecoTracker/TkDetLayers

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor

please test

@slava77
Copy link
Contributor

slava77 commented Feb 28, 2017

@ebrondol
please clarify if this changes anything other than that printout?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18012/console Started: 2017/02/28 16:35

@ebrondol
Copy link
Contributor Author

ebrondol commented Feb 28, 2017

@slava77 yes, printout and cleaning up.
No changes are expected in any physics result.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Mar 1, 2017

+1

for #17652 5ca39ef

  • removed unused (and partly broken) code in RecoTracker/TkDetLayers/src/GeometricSearchTrackerBuilder.cc ; this removes a caught exception at the start of the job in upgrade workflows
  • jenkins tests pass
    • comparisons with baseline show no differences
    • (as an example) wf 10021.0 step3 log file shows no exception anymore, compared to the baseline which has
in filling An exception of category 'InvalidReference' occurred.
Exception Message:
Trie::insert called with a key already in collection;
key value: ^A

304091140 1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1
thanks!

@cmsbuild cmsbuild merged commit 0c278bb into cms-sw:CMSSW_9_0_X Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants