New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nbOfDaughters_electrons_correction_Histos_90X_V2 #17672
nbOfDaughters_electrons_correction_Histos_90X_V2 #17672
Conversation
A new Pull Request was created by @archiron (Chiron) for CMSSW_9_0_X. It involves the following packages: Validation/RecoEgamma @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
Hi, We found out that due to the pruning of the GenParticle in the miniAOD. Indeed, one has [That said, I am surprised that the gamma->e+ + e- gets recorded in the original GenParticle collection, but that's off topic] For consistency, we applied the same check on the number of daughters in the RECO validation |
any update or pbm ? |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
Comparison job queued. |
+1 |
It is a modification of the validation code (ElectronMcMiniAODSignalValidator.cc & ElectronMcSignalValidator.cc) in order to avoid nbOfDaughters >2 (i.e. 3 or 4). This lead to difference in the entries for miniAOD if nbOfDaughters is >2.
in addition, a few files were cleaned to take into account the SingleElectronPtxx with SingleElectronPtxx_UP15 with xx = 10, 35, 1000.
@beaudett @fcouderc