Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbOfDaughters_electrons_correction_Histos_90X_V2 #17672

Merged
merged 1 commit into from Apr 12, 2017
Merged

nbOfDaughters_electrons_correction_Histos_90X_V2 #17672

merged 1 commit into from Apr 12, 2017

Conversation

archiron
Copy link
Contributor

@archiron archiron commented Mar 1, 2017

It is a modification of the validation code (ElectronMcMiniAODSignalValidator.cc & ElectronMcSignalValidator.cc) in order to avoid nbOfDaughters >2 (i.e. 3 or 4). This lead to difference in the entries for miniAOD if nbOfDaughters is >2.

in addition, a few files were cleaned to take into account the SingleElectronPtxx with SingleElectronPtxx_UP15 with xx = 10, 35, 1000.

@beaudett @fcouderc

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2017

A new Pull Request was created by @archiron (Chiron) for CMSSW_9_0_X.

It involves the following packages:

Validation/RecoEgamma

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@beaudett
Copy link
Contributor

beaudett commented Mar 1, 2017

Hi,
adding some information: this PR solves a long standing issue that we had in the miniAOD validation: the number of reco-electrons matched to gen electrons was sometimes different by 1 or 2 (more) in the validation of ttbar samples.
It should be mentioned that the gen electrons are coming from W's.

We found out that due to the pruning of the GenParticle in the miniAOD. Indeed, one has
W+->W+ + (gamma -> e+ + e-)
the intermediate particles (e.g. the gamma) are dropped and the W+ is set as parent of the e+ and of the e-. In that case, the W+ has 3 or 4 daughters and that's how we detect the problem.
In RECO/AOD, the intermediate particles are kept, so there is no problem.

[That said, I am surprised that the gamma->e+ + e- gets recorded in the original GenParticle collection, but that's off topic]

For consistency, we applied the same check on the number of daughters in the RECO validation

@archiron
Copy link
Contributor Author

any update or pbm ?

@dmitrijus
Copy link
Contributor

+1
I somehow missed this PR :(

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18521/console Started: 2017/03/17 17:09

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9eb7b37 into cms-sw:CMSSW_9_0_X Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants