Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bsunanda:Run2-TB23 Add the new AHCal for 2017 HGCal TB #17684

Merged
merged 1 commit into from Mar 5, 2017
Merged

bsunanda:Run2-TB23 Add the new AHCal for 2017 HGCal TB #17684

merged 1 commit into from Mar 5, 2017

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Mar 2, 2017

This is a preparatory setup for 2017 HGCal TB at CERN
Automatically ported from CMSSW_9_0_X #17659 (original by @bsunanda).

@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 2, 2017
@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 2, 2017

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

Geometry/HGCalCommonData
SimG4CMS/HGCalTestBeam

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ianna
Copy link
Contributor

ianna commented Mar 2, 2017

@smuzaffar is merging to cms-sw:master correct? why not cms-sw:CMSSW_9_0_X?

@smuzaffar
Copy link
Contributor

smuzaffar commented Mar 2, 2017 •
edited

Since today, we have open master branch as development branch. All open PRs of 90X are forward ported to master branch.

@ianna
Copy link
Contributor

ianna commented Mar 2, 2017

@smuzaffar - thanks!

@ianna
Copy link
Contributor

ianna commented Mar 2, 2017

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 2, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18048/console Started: 2017/03/02 12:42

@smuzaffar
Copy link
Contributor

test will not run as there is no 91X release yet available

@bsunanda
Copy link
Contributor

bsunanda commented Mar 2, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 2, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18079/console Started: 2017/03/02 17:09

@bsunanda
Copy link
Contributor

bsunanda commented Mar 2, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 2, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18089/console Started: 2017/03/03 00:04
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18090/console Started: 2017/03/03 00:12
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18091/console Started: 2017/03/03 00:35

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 3, 2017

+1
Tested at: f30b026
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17684/18091/summary.html

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 3, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17684/18091/summary.html

@ianna
Copy link
Contributor

ianna commented Mar 3, 2017

+1

@bsunanda
Copy link
Contributor

bsunanda commented Mar 3, 2017

@kpedro88 @civanch could you please approve this?

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 3, 2017

+1

@civanch
Copy link
Contributor

civanch commented Mar 4, 2017

+1

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 4, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c632840 into cms-sw:master Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed geometry-approved orp-approved simulation-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cmsbuild @ianna @smuzaffar @bsunanda @kpedro88 @civanch @davidlange6