remove photoelectronsToAnalog python parameter (now taken from DB) #17697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @cmsbuild for master. It involves the following packages: SimCalorimetry/CaloSimAlgos @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #17530, the
photoelectronsToAnalogparameter for HB, HE, and HO is always taken from the database. This makes the corresponding Python parameter in the simulation redundant and possibly confusing, so it has been removed.@bsunanda is it okay for the HcalTestBeam simulation to get these values only from the database as well? Please check the changes I made in this PR.
attn: @abdoulline @mariadalfonso
Automatically ported from CMSSW_9_0_X #17658 (original by @kpedro88).
Please wait for a new IB (12 to 24H) before requesting to test this PR.