Fix parentage provenance in corner case #17752
Conversation
This fixes a bug that caused the parentage and things that depend on the parentage to be wrong in a corner case where a SubProcess is used and a module in the SubProcess causes unscheduled execution to run a module in an earlier SubProcess or top level Process and the parentage is accessed through the ProductProvenanceRetriever (not using the getProvenance function from the Event or the Provenance returned by a Handle).
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: DataFormats/Provenance @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: fff43f6 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testRecoMETMETProducers had ERRORS |
|
Comparison job queued. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The unit test failure is unrelated to this pull request. |
This fixes a bug that caused the parentage and things
that depend on the parentage to be wrong in a corner
case where a SubProcess is used and a module in the SubProcess
causes unscheduled execution to run a module in an earlier
SubProcess or top level Process and the parentage is accessed
through the ProductProvenanceRetriever (not using the getProvenance
function from the Event or the Provenance returned by a Handle).
Also adds to the unit tests so this case is tested and Parentage in
general is better tested.