Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase cosmics MC step1 nevents #17758

Merged
merged 1 commit into from Mar 7, 2017
Merged

increase cosmics MC step1 nevents #17758

merged 1 commit into from Mar 7, 2017

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Mar 2, 2017

Filters applied in step1 passed 0 events for the default 10 input events.
Increased the nevents to 500 for non-super-pointing, and to 2000 for super-pointing loose
so that just under 10 events pass on average.

We missed failures in 2017 cosmics matrix tests in IBs because of this default of 10 events.

@kpedro88

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2017

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @GurpreetSinghChahal, @davidlange6, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 2, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2017

@slava77
Copy link
Contributor Author

slava77 commented Mar 2, 2017

@smuzaffar
it looks like jenkins/bot does not recognize the master branch correctly
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18085/console

fatal: Remote branch CMSSW_9_1_X not found in upstream official-cmssw

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 2, 2017

@slava77 it's possible that is actually a problem in git cms-init:
https://github.com/cms-sw/cms-git-tools/blob/master/git-cms-init#L179-L187
https://github.com/cms-sw/cms-git-tools/blob/master/git-cms-init#L365-L378

I'm not sure how it would know to clone from master instead of CMSSW_9_1_X...

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

-1

Tested at: 271b91c

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f516fca
ee4abab
a6d8919
7419eb5
27e9f65
3a47e93
d3010d0
2d932bf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17758/18092/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17758/18092/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17758/18092/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
10021.0 step3

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step3
runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f516fca
ee4abab
a6d8919
7419eb5
27e9f65
3a47e93
d3010d0
2d932bf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17758/18092/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17758/18092/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@smuzaffar
Copy link
Contributor

@slava77 and @kpedro88 , this is fixed and Pr tests should be working fine now

@slava77
Copy link
Contributor Author

slava77 commented Mar 3, 2017

   [69] Prefetching for module HBHEIsolatedNoiseReflagger/'hbhereco'
   [70] Calling method for module HBHEPlan1Combiner/'hbheplan1'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::SortedCollection<HBHERecHit,edm::StrictWeakOrdering<HBHERecHit> >
Looking for module label: hbheprerecoMB

@kpedro88 are these going to be fixed with #17751 ?

@slava77
Copy link
Contributor Author

slava77 commented Mar 3, 2017

@smuzaffar
do we have a cms-bot command to test with additional cmssw PRs?
As in this (manually submitted) build
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18128/console
?

@smuzaffar
Copy link
Contributor

@slava77, no we do not have yet this support but can be added.

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 3, 2017

@slava77 that was fixed with my second commit in #17751 last night

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

@slava77
Copy link
Contributor Author

slava77 commented Mar 3, 2017

@davidlange6 @fabozzi

the last set of tests
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18128/console
confirmed that the cosmics workflows ( MATRIX_EXTRAS='-l 7.0,7.1,7.2,1307.0') run on the modified default number of events with roughly expected selected event counts

  • 7.1 runs on 2000 step1 events and select 7 events for steps 2 and further
  • 7.0 and 7.2 runs on 500 events in step1 and selects 6 events for steps 2 and further

You can see these in the test logs
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17758/18128/runTheMatrix-results/

@fabozzi
Copy link
Contributor

fabozzi commented Mar 6, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants