Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiPixelPhase1 - Filter update #17761

Merged
merged 4 commits into from Mar 7, 2017

Conversation

yimuchen
Copy link
Contributor

@yimuchen yimuchen commented Mar 3, 2017

  • Added functionality to SiPixelPhase1Base to allow for filter filtering using the GenericTriggerFlag class

    • Trigger filtering defined in SiPixelPhase1Base:checktrigger()
    • Example codes in comments of SiPixelPhase1Clusters, interface similar to the existing HistogramManger setting with enums and cms.VPsets
  • Added new geometry of PXAll which is inclusive a inclusive set for PXBarrel and PXForward

@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 3, 2017
@yimuchen yimuchen changed the title SiPixlePhase1 - Filter update SiPixelPhase1 - Filter update Mar 3, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

A new Pull Request was created by @enochnotsocool (Enoch Chen) for master.

It involves the following packages:

DQM/SiPixelPhase1Clusters
DQM/SiPixelPhase1Common

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@fioriNTU
Copy link
Contributor

fioriNTU commented Mar 6, 2017

@dmitrijus can you start the tests please?

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18206/console Started: 2017/03/07 14:14

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

Comparison job queued.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a5138d1 into cms-sw:master Mar 7, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants