Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and adding a Fake2 HLT menu (91X) #17796

Merged
merged 6 commits into from Mar 7, 2017

Conversation

Martin-Grunewald
Copy link
Contributor

Adding a Fake2 HLT menu (91X)
Based on CMSSW_9_1_X_2017-03-05-2300

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @geoff-smith, @jalimena this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18165/console Started: 2017/03/06 16:25

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

Pull request #17796 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18174/console Started: 2017/03/06 18:25

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

Pull request #17796 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18210/console Started: 2017/03/07 15:03

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@Martin-Grunewald Martin-Grunewald changed the title Adding a Fake2 HLT menu (91X) Bug fixes and adding a Fake2 HLT menu (91X) Mar 7, 2017
@Martin-Grunewald
Copy link
Contributor Author

type bug-fix

@davidlange6
Copy link
Contributor

+1

(but there are certainly more self-documenting names for this new menu than 'fake2'.. perhaps one could be considered in the near future. Thanks )

@cmsbuild cmsbuild merged commit 61aef7a into cms-sw:master Mar 7, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants