Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed legacy b tagging using tight track selection from MiniAOD #17839

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Mar 8, 2017

This PR addresses the issue discussed in #17573

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

A new Pull Request was created by @ferencek (Dinko Ferencek) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 8, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18266/console Started: 2017/03/09 00:54

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

@perrotta
Copy link
Contributor

+1
Tiny differences in the slimmed jets, and in the DQM analyses which use them.
No significant effect on the event size (tiny reduction, though)

@slava77
Copy link
Contributor

slava77 commented Mar 21, 2017

@perrotta
jenkins comparisons report is not available anymore.
which differences did you see in the slimmed jets and where?
Please clarify.
Thank you.

@perrotta
Copy link
Contributor

perrotta commented Mar 21, 2017 via email

@slava77
Copy link
Contributor

slava77 commented Mar 21, 2017

@cmsbuild please test

@perrotta
Copy link
Contributor

please test
(addon's failed beacause of file access issues)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18721/console Started: 2017/03/27 12:06

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Mar 27, 2017

+1

@perrotta
Copy link
Contributor

+1
(Once again)
No significant effect on the event size (tiny reduction, though)
Differences are observed in the slimmed jets related plots: however, they look like being due to different roundings originated by having touched the slimmed jets, and do not affect significantly the jet parameters, see e.g.
--- Muon Energy fraction's in slimmed jets:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_1_X_2017-03-26-1100+17839/19027/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/JetMET_JetValidation_slimmedJets.html
--- Event logger in Physics/Top/SingleTopElectronMediumDQM_miniAOD:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_1_X_2017-03-26-1100+17839/19027/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/Physics_Top_SingleTopElectronMediumDQM_miniAOD_presel.html

@perrotta
Copy link
Contributor

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0169d33 into cms-sw:master Mar 28, 2017
@ferencek ferencek deleted the NoLegacyBTaggingInMiniAOD-PR_from-CMSSW_9_1_X_2017-03-08-1100 branch March 28, 2017 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants