Fix memory leak in BasicHepMCValidation

[Dr15Jones]

The code was creating a new HepMC::GenParticle and never deleting it.
Turns out there was no need to create a new one for the algorithm.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Validation/EventGenerator

@perrozzi, @thuer, @dmitrijus, @cmsbuild, @vanbesien, @govoni, @davidlange6 can you please review it and eventually sign? Thanks.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18302/console Started: 2017/03/09 18:20

[cmsbuild]

+1
Tested at: e19327a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17861/18302/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d6d088f
588950a
524c79f
b17f5c6
0670aa0
ae72ff2
a7179d1
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17861/18302/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17861/18302/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17861/18302/summary.html

[perrozzi]

+1

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[davidlange6]

+1