Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set HCAL method 3 respons to 1.0 for data and MC. #17871

Merged
merged 1 commit into from Mar 15, 2017
Merged

Set HCAL method 3 respons to 1.0 for data and MC. #17871

merged 1 commit into from Mar 15, 2017

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 9, 2017

Assume that retuning the pulse shapes will give the same response for Method 2 and Method 3, both for data and MC.

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Mar 9, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_9_0_X.

It involves the following packages:

HLTrigger/Configuration
RecoLocalCalo/HcalRecProducers

@perrotta, @cmsbuild, @silviodonato, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mariadalfonso, @geoff-smith, @jalimena this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18313/console Started: 2017/03/09 23:30

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 9, 2017

backport of #17872

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 9, 2017

Note that this does not change the value used in the HLT menus.
Those should be changed independently, via CMSHLT-1212, and the merged in the release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

+1
Tested at: 8128600
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17871/18313/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17871/18313/summary.html

@Martin-Grunewald
Copy link
Contributor

+1

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 13, 2017

Please merge !

@perrotta
Copy link
Contributor

+1
Same as #17872

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #17871 was updated. @perrotta, @cmsbuild, @silviodonato, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 14, 2017

rebsed, removing the file that was already removed

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 14, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18423/console Started: 2017/03/14 21:32

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 14, 2017

@davidlange6 , if the tests pass, can you merge ?

@cmsbuild
Copy link
Contributor

+1
Tested at: 5e37013
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17871/18423/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
937a0f7
7da5de9
3541ebc
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17871/18423/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17871/18423/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17871/18423/summary.html

@Martin-Grunewald
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+1
(again...)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 869c7c5 into cms-sw:CMSSW_9_0_X Mar 15, 2017
@mariadalfonso mariadalfonso mentioned this pull request Mar 21, 2017
Merged
@davidlange6 davidlange6 mentioned this pull request Mar 24, 2017
Closed
@fwyzard fwyzard deleted the set_respCorrM3_to_1.0 branch July 11, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport comparison-available fully-signed hlt-approved orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fwyzard @cmsbuild @Martin-Grunewald @perrotta @davidlange6