added fragment

[civanch]

Addition of a fragment needed for 13 TeV FastSim validation

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_0_X.

added fragment

It involves the following packages:

FastSimulation/PileUpProducer

@cmsbuild, @nclopezo, @giamman, @lveldere can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[civanch]

This new fragment was created according Andrea Giammanco proposal. A fragment is added which should be used for validation of FastSim at 13 TeV

[giamman]

+1

[giamman]

@franzoni and @vlimant can you please do the modifications needed to use this fragment in future relvals?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

[vlimant]

Hi Andrea,

how does this get picked up from cmsDriver ?
Have you inserted this in the Mixing.py ?

Cheers,
Jean-Roch.

On 12/12/13 7:19 PM, Andrea Giammanco wrote:

@franzoni https://github.com/franzoni and @vlimant
https://github.com/vlimant can you please do the modifications needed
to use this fragment in future relvals?

—
Reply to this email directly or view it on GitHub
#1788 (comment).

---

           ** Dr. Jean-Roch VLIMANT **
   CMS experiment,  CERN - Physics department

CERN Office: 40-3-A28 tel: +41 22 767 1209

CERN CMS Secretariat fax: +41 22 767 8940

[giamman]

Hi Jean-Roch, I thought that the recommendation was not to commit a new Mixing.py directly and let the specific experts do it. Or maybe this was a very old practice in the cvs times, and now, with github, people are recommended to change Mixing.py directly? Or am I mixing up with some other "central" python file that has nothing to do with mixing? Last time that I added a pile-up option was long ago (and I have a terribly bad memory), sorry.
Anyway, I would add:

addMixingScenario("FS_2012_Summer_inTimeOnly13TeV",{'file': 'FastSimulation.PileUpProducer.PileUpSimulator_2012_Summer_inTimeOnly13TeV_cff'})

after line 107 of Configuration/StandardSequences/python/Mixing.py

Then I suppose that more files will have to modified elsewhere to make this scenario picked up by relvals, but I would prefer to let this to you, to avoid messing things up.
Do you prefer to update Vladimir's pull request to add the modification to Configuration/StandardSequences/python/Mixing.py plus the other files on which relval production depends, or make these modifications part of a new pull request that will depend on this one?

Thanks,
Andrea

---

Andrea Giammanco
Phone (CERN): +41 22 76 71567
Mobiles: +41 76 2323672 (CH), +32 493 581662 (BE), +39 349 5552471 (IT)

---

From: vlimant [notifications@github.com]
Sent: 12 December 2013 19:27
To: cms-sw/cmssw
Cc: Andrea Giammanco
Subject: Re: [cmssw] added fragment (#1788)

Hi Andrea,

how does this get picked up from cmsDriver ?
Have you inserted this in the Mixing.py ?

Cheers,
Jean-Roch.

On 12/12/13 7:19 PM, Andrea Giammanco wrote:

@franzoni https://github.com/franzoni and @vlimant
https://github.com/vlimant can you please do the modifications needed
to use this fragment in future relvals?

—
Reply to this email directly or view it on GitHub
#1788 (comment).

---

** Dr. Jean-Roch VLIMANT **
CMS experiment, CERN - Physics department
CERN Office: 40-3-A28 tel: +41 22 767 1209

CERN CMS Secretariat fax: +41 22 767 8940

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1788#issuecomment-30448040.

[ktf]

Hi Jean-Roch, I thought that the recommendation was not to commit a
new Mixing.py directly and let the specific experts do it. Or maybe
this was a very old practice in the cvs times, and now, with github,
people are recommended to change Mixing.py directly?

I will not comment on wether or not Mixing.py or anything should be
changed by some expert or not, for sure it will require Jean Roch /
Giovanni / Fabio sign off, though. What is sure is that the CVS
restriction: "Release Manager please pickup a single file / revision
because otherwise we make a mess with tags" is lifted.

[giamman]

Thanks for clarifying, Giulio.
I am disconnecting now, and I don't know when I will connect again. So if the deadline is very soon, please don't wait for me...

[ktf]

Thanks for clarifying, Giulio.
I am disconnecting now, and I don't know when I will connect again. So
if the deadline is very soon, please don't wait for me...

Allegedly the deadline is next wed. BTW, what happened to the promise of
dropping the 1GB pileup data files?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1788/1731/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?