New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for MakeSherpaLibs and update of example cards #17888
Conversation
pmillet
commented
Mar 10, 2017
- fixed wrong naming of tarball when using -o LIBS in MakeSherpaLibs.sh
- replaced deprecated example runcards with recent examples
- fixed wrong naming of tarball when using -o LIBS in MakeSherpaLibs.sh - replaced deprecated example runcards with recent examples
A new Pull Request was created by @pmillet for master. It involves the following packages: GeneratorInterface/SherpaInterface @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |