Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for MakeSherpaLibs and update of example cards #17888

Merged
merged 1 commit into from Mar 12, 2017

Conversation

pmillet
Copy link
Contributor

@pmillet pmillet commented Mar 10, 2017

  • fixed wrong naming of tarball when using -o LIBS in MakeSherpaLibs.sh
  • replaced deprecated example runcards with recent examples

- fixed wrong naming of tarball when using -o LIBS in MakeSherpaLibs.sh
- replaced deprecated example runcards with recent examples
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pmillet for master.

It involves the following packages:

GeneratorInterface/SherpaInterface

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano, @thuer this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@perrozzi
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18346/console Started: 2017/03/10 23:58

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17888/18346/summary.html

There are some workflows for which there are errors in the baseline:
1330.0 step 2
25202.0 step 1
136.731 step 3
1306.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@perrozzi
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants