Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Phase2-gem24 Fix the issue of GE21 with staggered gap #17889

Merged
merged 2 commits into from Mar 18, 2017

Conversation

bsunanda
Copy link
Contributor

This enables testing of the numbering scheme of GE21 with staggered gap

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 10, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18347/console Started: 2017/03/11 00:06

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/GEMGeometry
Geometry/GEMGeometryBuilder
Geometry/MuonCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @ptcox this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17889/18347/summary.html

There are some workflows for which there are errors in the baseline:
1330.0 step 2
25202.0 step 1
136.731 step 3
1306.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@ianna
Copy link
Contributor

ianna commented Mar 11, 2017

+1

@bsunanda
Copy link
Contributor Author

@kpedro88 Can you sign this one?

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #17889 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18492/console Started: 2017/03/16 16:13

@ianna
Copy link
Contributor

ianna commented Mar 16, 2017

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@bsunanda
Copy link
Contributor Author

@kpedro88 Please approve this

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@bsunanda
Copy link
Contributor Author

@davidlange6 Should it be back ported to 9_0_X? My understanding from Piet's message is that muon group wants this to be a part of Muon TDR studies.

@kpedro88
Copy link
Contributor

@bsunanda 9_0_0 will only be used for L1 TDR studies - muon TDR will use 9_1_0 prereleases (most likely)

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 17, 2017 via email

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d653539 into cms-sw:master Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants