New cluster shape filter for phase2 + adding PixelPair #17891

VinInn · 2017-03-11T13:33:59Z

This Pr includes three main changes (all connected )

add a New cluster shape filter for phase2
1a) I explicitly added two files for two efficiency WP 99.5 and 99.9 the default (at the moment a copy) is 99.5
add (back) a PixelPair iteration to recover any inefficiency of the triplet step
(so PixelPair cover only the regions not covered by quadruplets)
make HighPtTriplets and PixelPair seed-extensions...

MTV
1000 single muon (blue pre5, red WP99p5, orange Wp99p9, black this PR)
http://innocent.home.cern.ch/innocent/RelVal/Muon10csf99/plots_ootb/effandfake1.pdf
250 ttbar PU200 (blue pre5, red WP99p9, black Wp99p5, orange this PR)
http://innocent.home.cern.ch/innocent/RelVal/ttbar200PUcsf/plots_ootb/effandfake1.pdf

timing ttbar PU200 tracking only +DQM
900_pre5

TimeReport ---------- Event  Summary ---[sec]----
TimeReport       event loop CPU/event = 202.108402
TimeReport      event loop Real/event = 35.805349
TimeReport     sum Streams Real/event = 203.915857

this PR

TimeReport ---------- Event  Summary ---[sec]----
TimeReport       event loop CPU/event = 146.413452
TimeReport      event loop Real/event = 25.872114
TimeReport     sum Streams Real/event = 148.02895

obsoletes #17810

cmsbuild · 2017-03-11T13:34:17Z

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

RecoPixelVertexing/PixelLowPtUtilities
RecoTracker/FinalTrackSelectors
RecoTracker/IterativeTracking

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

VinInn · 2017-03-11T13:35:01Z

@cmsbuild please test

cmsbuild · 2017-03-11T13:35:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18350/console Started: 2017/03/11 14:44

VinInn · 2017-03-11T13:35:33Z

assign upgrade

VinInn · 2017-03-11T13:36:06Z

@kandrosov @venturia

VinInn · 2017-03-11T13:36:40Z

@boudoul

VinInn · 2017-03-11T13:36:59Z

@ebrondol

cmsbuild · 2017-03-11T15:26:15Z

+1
Tested at: bb2e881
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17891/18350/summary.html

cmsbuild · 2017-03-11T15:26:18Z

Comparison job queued.

cmsbuild · 2017-03-11T16:39:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17891/18350/summary.html

ebrondol · 2017-03-13T10:55:05Z

RecoTracker/IterativeTracking/python/HighPtTripletStep_cff.py

@@ -150,10 +158,12 @@
 )
 trackingPhase1PU70.toModify(highPtTripletStepTrajectoryBuilder,
    MeasurementTrackerName = '',
-    maxCand = 4,


@makortel do you want to change this? I thought that this era was frozen.

Doesn't matter, trackingPhase1PU70 is not used in any workflow, and I'll clean it up sometime soon.

ebrondol · 2017-03-13T10:59:15Z

Thanks @VinInn . Can you please describe the legend in the files you have posted?

slava77 · 2017-03-13T16:28:50Z

assign upgrade

cmsbuild · 2017-03-13T16:29:06Z

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

slava77 · 2017-03-16T17:29:28Z

@VinInn
what is the purpose of the new files?
They are not used in this PR.

Is it "for upcoming developments"?

VinInn · 2017-03-16T17:50:23Z

I added the files to allow people to easily test different options changing just the config...

slava77 · 2017-03-16T19:24:02Z

Some plots from PU200 (baseline 900pre6):

some large reduction of "bad" PVs

Pretty large reduction in electron seeds (/2.5) with better matching ones retained

downstream we have two times less electronGsfTracks

ecal driven electron reduction is mainly in the barrel (apparently mostly fakes; based on MTV GSF eff plots)

Inclusive muon distribution is still full of fakes [a part of it is a feature of what's reconstructed/saved, not necessarily fake tracks]

number of generalTracks is down (almost all of this reduction is from tracks with less than 7 hits)

PF CH (~high purity tracks) are less affected suggesting relatively high purity here already

.... ..... ..... ......

DQM plots:

wf 21211 (10 muons extended eta range)
muon efficiencies have some visible loss in eta>3.5, while below that the efficiency looks about the same (a bit up/down in a few bins)

In PU200 ttbar
track fake rate is down by x2 or even more in some regions [in line with the supplied MTV plots]
mainly at low pt

PV fake rate is down

b-tagging is improved moderately

.... ..... ..... ......

On the technical side, based on PU200:

miniAOD output size is down by 5%; RECO (which is actually FEVT) is down by 10%
total CPU time in reco+miniAOD is reduced by 1.5 from 600 to 400 s/event [in my 10HS06 seconds]
- iterative tracking "proper" (*Step* module names from tracking) is down by a bit more than twice: from 270 s to 120 s/evt
- note that this check is before 4D PV timing went up by x3; after this PR in 91X it's probably heavier than all of tracking
memory is down by about 200 MB/core (the job includes validation sequences; proper reco may reduce by less)

Overall, looks like a very welcome change.

kpedro88 · 2017-03-16T19:27:23Z

Indeed, a nice improvement both for physics and resource usage

slava77 · 2017-03-16T19:28:21Z

+1

for #17891 bb2e881

implemented as described; main improvement are from the cluster shape cuts with some recovery from the pixel doublets
jenkins tests pass and comparisons with baseline show changes only in 2023 workflows; changes start from tracking as expected
local tests with 10-mu and TTbarPU200 samples show improvements in behavior, as posted above

kpedro88 · 2017-03-16T19:28:55Z

+1

cmsbuild · 2017-03-16T19:29:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

davidlange6 · 2017-03-16T19:46:23Z

+1

ebrondol · 2017-03-17T09:58:25Z

@slava77 did you also performed the check on D11? Or just a rough idea if my report in PR #17919 is compatible with your report?

slava77 · 2017-03-17T11:49:32Z

On 3/17/17 2:58 AM, ebrondol wrote: @slava77 <https://github.com/slava77> did you also performed the check on D11? Or just a rough idea if my report in PR #17919 <#17919> is compatible with your report?

No, I did not check D11. Remind me please the significance of it. From README: D4 = T3+C2+M1+I1 D11 = T5+C2+M1+I1 and T3: Phase2 tilted tracker (v3.6.5) w/ phase 2 pixel (v4.0.2.6) T5: Phase2 tilted tracker (v3.6.5) w/ phase 2 pixel (v4.0.2.5) {the pixel (v4.0.2.5) has one more FPIX disk} Is this 8+4 pixel going to become the new default or is it a side-test?

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17891 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbp-ga4OwKFqSaK53XikbFt946Jkeks5rmllCgaJpZM4MaNHE>.

ebrondol · 2017-03-17T11:54:40Z

As far as I understood, the nomenclature T3 and T5 will remain the same with the idea of having a "validated tracker" (T3) and a "testing tracker" (T5). If T5 will succeed the tests and the validation we are going to do with the next RelVal production, it will become the new default (T3).
@boudoul @kpedro88 please confirm if I am correct.

slava77 · 2017-03-17T12:09:25Z

On 3/17/17 4:54 AM, ebrondol wrote: As far as I understood, the nomenclature T3 and T5 will remain the same with the idea of having a "validated tracker" (T3) and a "testing tracker" (T5). If T5 will succeed the tests and the validation we are going to do with the next RelVal production, it will become the new default (T3). @boudoul <https://github.com/boudoul> @kpedro88 <https://github.com/kpedro88> please confirm if I am correct.

One more disk is probably an increment in cost, but if that's becoming a default, OK, I will move to it once it's clear. No intention so far to check two workflows in parallel from my side ... at least not until we stop writing more than 100MB/event in step3 workflows.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17891 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbpvJ_Px6ND0Xyt87BnE8SWTF5B6Zks5rmnSBgaJpZM4MaNHE>.

kpedro88 · 2017-03-17T13:05:15Z

@ebrondol that wasn't really my understanding... if there's going to be another new tracker, I assumed it would get its own number. What you propose could be done, but since we are preparing for more TDR productions, we need to be very careful about changing the baseline geometry.

boudoul · 2017-03-17T13:20:45Z

Dear all , we are keeping T3 , mostly because all production which has been done so far (and presumably more to come) are all based on T3 - Physics results for the tracker TDR are and will be based on T3 - However T3 is not a version that eventually will be in the real detector, and we are devloping T5 with with respect- T5 will be used to derive tracker-tracking performance (eventually to be also added within the TDR) , but indeed we should keep T3 (not merging or at least not in a short time scale defined by TDRs)

VinInn added 4 commits March 4, 2017 19:07

speedup triplets

7168a5a

add pixelpair

c6f82d9

lower ptcut

d4c028b

clean config, add explicitely WP99p5/9

bb2e881

cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 11, 2017

cmsbuild added comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 11, 2017

cmsbuild added tests-started and removed tests-pending labels Mar 11, 2017

cmsbuild added tests-approved and removed tests-started labels Mar 11, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 11, 2017

ebrondol reviewed Mar 13, 2017

View reviewed changes

slava77 mentioned this pull request Mar 13, 2017

Updated ClusterShapeHitFilter calibration for Phase 2. #17810

Closed

cmsbuild added the upgrade-pending label Mar 13, 2017

ebrondol mentioned this pull request Mar 14, 2017

Re-insert layer 678 in PFX to recover efficiency in D11 wf #17919

Merged

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 16, 2017

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Mar 16, 2017

cmsbuild added orp-approved and removed orp-pending labels Mar 16, 2017

cmsbuild merged commit 5e507f4 into cms-sw:master Mar 16, 2017

makortel mentioned this pull request May 31, 2017

Mitigation for inactive pixel regions for phase1 tracking #19051

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New cluster shape filter for phase2 + adding PixelPair #17891

New cluster shape filter for phase2 + adding PixelPair #17891

VinInn commented Mar 11, 2017 •

edited

cmsbuild commented Mar 11, 2017

VinInn commented Mar 11, 2017

cmsbuild commented Mar 11, 2017 •

edited

VinInn commented Mar 11, 2017

VinInn commented Mar 11, 2017

VinInn commented Mar 11, 2017

VinInn commented Mar 11, 2017

cmsbuild commented Mar 11, 2017

cmsbuild commented Mar 11, 2017

cmsbuild commented Mar 11, 2017

ebrondol Mar 13, 2017

makortel Mar 13, 2017

ebrondol commented Mar 13, 2017

slava77 commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

slava77 commented Mar 16, 2017

VinInn commented Mar 16, 2017

slava77 commented Mar 16, 2017

kpedro88 commented Mar 16, 2017

slava77 commented Mar 16, 2017

kpedro88 commented Mar 16, 2017

cmsbuild commented Mar 16, 2017

davidlange6 commented Mar 16, 2017

ebrondol commented Mar 17, 2017

slava77 commented Mar 17, 2017 via email

ebrondol commented Mar 17, 2017

slava77 commented Mar 17, 2017 via email

kpedro88 commented Mar 17, 2017

boudoul commented Mar 17, 2017

New cluster shape filter for phase2 + adding PixelPair #17891

New cluster shape filter for phase2 + adding PixelPair #17891

Conversation

VinInn commented Mar 11, 2017 • edited

cmsbuild commented Mar 11, 2017

VinInn commented Mar 11, 2017

cmsbuild commented Mar 11, 2017 • edited

VinInn commented Mar 11, 2017

VinInn commented Mar 11, 2017

VinInn commented Mar 11, 2017

VinInn commented Mar 11, 2017

cmsbuild commented Mar 11, 2017

cmsbuild commented Mar 11, 2017

cmsbuild commented Mar 11, 2017

ebrondol Mar 13, 2017

Choose a reason for hiding this comment

makortel Mar 13, 2017

Choose a reason for hiding this comment

ebrondol commented Mar 13, 2017

slava77 commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

slava77 commented Mar 16, 2017

VinInn commented Mar 16, 2017

slava77 commented Mar 16, 2017

kpedro88 commented Mar 16, 2017

slava77 commented Mar 16, 2017

kpedro88 commented Mar 16, 2017

cmsbuild commented Mar 16, 2017

davidlange6 commented Mar 16, 2017

ebrondol commented Mar 17, 2017

slava77 commented Mar 17, 2017 via email

ebrondol commented Mar 17, 2017

slava77 commented Mar 17, 2017 via email

kpedro88 commented Mar 17, 2017

boudoul commented Mar 17, 2017

VinInn commented Mar 11, 2017 •

edited

cmsbuild commented Mar 11, 2017 •

edited