New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eta range for HCAL LUT metadata #17895
Fix eta range for HCAL LUT metadata #17895
Conversation
A new Pull Request was created by @christopheralanwest for master. It involves the following packages: CalibCalorimetry/HcalPlugins @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 no questions asked on the 'magic' :-) numbers , given that we have HcalHardcodeCalibrations.cc More seriously: |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
Comparison job queued. |
+1 |
This corrects the trigger LUT granularity and threshold in the HCAL hardcode calibrations to the values that are actually used. This change should have no effect on any code that does not explicitly request the hardcode calibrations.