Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eta range for HCAL LUT metadata #17895

Merged

Conversation

christopheralanwest
Copy link
Contributor

This corrects the trigger LUT granularity and threshold in the HCAL hardcode calibrations to the values that are actually used. This change should have no effect on any code that does not explicitly request the hardcode calibrations.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

CalibCalorimetry/HcalPlugins

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@franzoni
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18395/console Started: 2017/03/14 16:31

@franzoni
Copy link

+1

no questions asked on the 'magic' :-) numbers , given that we have HcalHardcodeCalibrations.cc

More seriously:
are these values and changes reflect in database payloads
in HcalLUTCorrsRcd or HcalLutMetadataRcd ?

@hatakeyamak @deguio @arunhep @walterjr @abdoulline

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit eed6a33 into cms-sw:master Mar 15, 2017
@christopheralanwest christopheralanwest deleted the hcal-update-hardcode-calib-91X branch August 21, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants