Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added comments to ChainEvent::fileIndex() #1791

Merged
merged 1 commit into from Dec 15, 2013

Conversation

jpata
Copy link
Contributor

@jpata jpata commented Dec 12, 2013

Acting upon https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3206/1.html, comments regarding the meaning of fwlite::ChainEvent::fileIndex() have been added to the ChainEvent.h header file.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jpata (Joosep Pata) for CMSSW_7_0_X.

added comments to ChainEvent::fileIndex()

It involves the following packages:

DataFormats/FWLite

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor

+1
Thanks

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1791/1741/summary.html

@nclopezo
Copy link
Contributor

it seems to be unrelated, I will start the tests again.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@Dr15Jones
Copy link
Contributor

@nclopezo did this test get run again?
@ktf this was only change to comments and is only used for FWLite.

ktf added a commit that referenced this pull request Dec 15, 2013
FWLite documentation -- Added comments to ChainEvent::fileIndex()
@ktf ktf merged commit 9cf05cd into cms-sw:CMSSW_7_0_X Dec 15, 2013
@jpata jpata deleted the jpata/chainevent_fileindex_comments branch February 26, 2015 16:36
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Update Root to the tip of the branch 6.02.00-patches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants