Muon HLT for IterL3: porting to new seeding

[folguera]

Modified MuonTrackingRegionBuilder to be compatible with the new seeding algorithm for the iterative tracking.

Was #17924 in 91X

[cmsbuild]

A new Pull Request was created by @folguera (Santiago Folgueras) for master.

It involves the following packages:

RecoMuon/GlobalTrackingTools

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @battibass, @trocino, @amagitte, @bachtis, @rociovilar this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18428/console Started: 2017/03/14 22:45

[cmsbuild]

-1

Tested at: d0b5245

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17925/18428/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-14-1600/src/RecoMuon/GlobalTrackingTools/plugins/Module.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-14-1600/src/RecoMuon/GlobalTrackingTools/plugins/GlobalTrackQualityProducer.cc 
Entering library rule at RecoMuon/L3MuonProducer
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-14-1600/src/RecoMuon/L3TrackFinder/plugins/SealModules.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-14-1600/src/RecoMuon/L3TrackFinder/src/L3MuonTrajectoryBuilder.cc: In static member function 'static void L3MuonTrajectoryBuilder::fillDescriptions(edm::ParameterSetDescription&)':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-14-1600/src/RecoMuon/L3TrackFinder/src/L3MuonTrajectoryBuilder.cc:76:55: error: no matching function for call to 'MuonTrackingRegionBuilder::fillDescriptions(edm::ParameterSetDescription&)'
    MuonTrackingRegionBuilder::fillDescriptions(descTRB);
                                                       ^
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-14-1600/src/RecoMuon/L3TrackFinder/src/L3MuonTrajectoryBuilder.cc:48:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-14-1600/src/RecoMuon/GlobalTrackingTools/interface/MuonTrackingRegionBuilder.h:63:17: note: candidate: static void MuonTrackingRegionBuilder::fillDescriptions(edm::ConfigurationDescriptions&)
     static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #17925 was updated. @perrotta, @cmsbuild, @silviodonato, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18462/console Started: 2017/03/15 22:58

[cmsbuild]

+1
Tested at: 731721a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17925/18462/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17925/18462/summary.html

There are some workflows for which there are errors in the baseline:
25.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

[Martin-Grunewald]

+1

[perrotta]

+1

• Reorganized ParameterSetDescription in MuonTrackingRegionBuilder to be compatible with the new seeding algorithm for the IT
• No changes expected in the results, no changes observed in jenkins tests

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[davidlange6]

+1