Fixed memory problem in PrimaryVertexAnalyzer4PU #1793
Conversation
PrimaryVertexANalyzer4PU was allocating an array of arrays using new[] but failed to use delete[]. The problem was found by the static analyzer. Rather than fix the fragile delete, I switched to code to use container objects which manage their own memory. This also meant changing a function to return a std::vector<int> rather than an int* and requiring the caller to remember to delete the item (there wrong delete was being used there anyway).
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X. Fixed memory problem in PrimaryVertexAnalyzer4PU It involves the following packages: Validation/RecoVertex @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
…exAnalyzer4PU Falidation fix -- Fixed memory problem in PrimaryVertexAnalyzer4PU
PrimaryVertexANalyzer4PU was allocating an array of arrays using new[] but failed to use delete[]. The problem was found by the static analyzer. Rather than fix the fragile delete, I switched to code to use container objects which manage their own memory. This also meant changing a function to return a std::vector rather than an int* and requiring the caller to remember to delete the item (there wrong delete was being used there anyway).