fix for ECAL selective readout

[franzoni]

This PR deploys the fix to ECAL selective readout already introduced in the lat ocmmit of the 90x #17886

Summary of changes in Global Tags

Upgrade

• PhaseII realistic scenario : 90X_upgrade2023_realistic_v9 as 90X_upgrade2023_realistic_v8 with the following changes:

  • ECAL: 2017 selective readout (fix) https://indico.cern.ch/event/615692/contributions/2484421/

• PhaseI 2017 cosmics peak scenario : 90X_upgrade2017cosmics_realistic_peak_v18 as 90X_upgrade2017cosmics_realistic_peak_v17 with the following changes:

  • ECAL: 2017 selective readout (fix) - https://indico.cern.ch/event/615692/contributions/2484421/

• PhaseI 2017 cosmics scenario : 90X_upgrade2017cosmics_realistic_deco_v17 as 90X_upgrade2017cosmics_realistic_deco_v16 with the following changes:

  • ECAL: 2017 selective readout (fix) - https://indico.cern.ch/event/615692/contributions/2484421/

• PhaseI 2017 realistic scenario : 90X_upgrade2017_realistic_v19 as 90X_upgrade2017_realistic_v18 with the following changes:

  • ECAL: 2017 selective readout (fix) - https://indico.cern.ch/event/615692/contributions/2484421/

• PhaseI 2018 cosmics scenario : 90X_upgrade2018cosmics_realistic_deco_v16 as 90X_upgrade2018cosmics_realistic_deco_v15 with the following changes:

  • ECAL: 2017 selective readout (fix) - https://indico.cern.ch/event/615692/contributions/2484421/

• PhaseI 2018 realistic scenario : 90X_upgrade2018_realistic_v16 as 90X_upgrade2018_realistic_v15 with the following changes:

  • ECAL: 2017 selective readout (fix) - https://indico.cern.ch/event/615692/contributions/2484421/

[cmsbuild]

A new Pull Request was created by @franzoni (Giovanni Franzoni) for master.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @tocheng this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[arunhep]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18427/console Started: 2017/03/14 21:54

[cmsbuild]

-1

Tested at: 0639ee8

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17936/18427/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
10024.0 step4

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step4_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[franzoni]

the error looks unrelated to the GT change

[franzoni]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18441/console Started: 2017/03/15 10:54

[cmsbuild]

+1
Tested at: 0639ee8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17936/18441/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17936/18441/summary.html

[arunhep]

@franzoni still the same observation in ECAL plots. Change in occupancy in EB [1]
and no change in EE [2]

[1] : https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_1_X_2017-03-14-2300+17936/18798/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/EcalBarrel_EBOccupancyTask.html

[2] : https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_1_X_2017-03-14-2300+17936/18798/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/EcalEndcap.html

[franzoni]

@cmkuo
@shervin86
@emanueledimarco

Ecal experts and the lack of impact in EE: may you please comment?
This condition change in this pr assesses only the difference between the C1-scenario-with-problem (provided two weeks ago)
To the tag you released yesterday with the fix.

Does the fix pertain only EB?

[amassiro]

The fix can have slightly different effects in EE and in EB due to different pulse shapes.
It will be explained in details tomorrow: https://indico.cern.ch/event/622160/

[franzoni]

Difference in EE occupancy are actually there.
The relmon comparisons ( as already explained here #17886 (comment) ) show differences when a loose bin-to-bin comparison, and the EE differences don't fail the check on the pseudo-chi2 which flags them as "difference.
Below the change in occupancy for EB and EE, red is target (i.e. the GT 2017 realistic of this PR, TTbar), blue is the reference (i.e. the SR/ZS affected by the bug which this PR intends to fix).

[franzoni]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[davidlange6]

+1