Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag&probe package for egm [80X PR] #17940

Merged
merged 1 commit into from Apr 5, 2017

Conversation

fcouderc
Copy link
Contributor

same as PR #17820

egm tnp package has diverged from central repository for quite a while now.
Fix this by:

updating the central PhysicsTools/TagAndProbe to fulfil egm needs
add a new package in cms-analysis for egm specific tnp tree making
This PR has been reviewed by muon conveners so that it does not change the muon tnp tree contents.
@HuguesBrun

It will be needed for legacy re-reco analysis and hence will also be committed in 80X (this PR) .

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fcouderc for CMSSW_8_0_X.

It involves the following packages:

DataFormats/RecoCandidate
PhysicsTools/TagAndProbe

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @gouskos this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 15, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18449/console Started: 2017/03/15 13:35

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@perrotta
Copy link
Contributor

+1
(same as #17820 in 91X)

@cmsbuild
Copy link
Contributor

@fcouderc
Copy link
Contributor Author

Just to check if there is any problem with this one?
Thanks

@perrotta
Copy link
Contributor

+1
Same as #17820 (in 91X) and #17959 (in 90X)

@perrotta
Copy link
Contributor

@fcouderc : indeed it just slipped in. Thank you for checking!

@fcouderc
Copy link
Contributor Author

thanks a lot!

@monttj
Copy link
Contributor

monttj commented Mar 27, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 648f589 into cms-sw:CMSSW_8_0_X Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants