Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023 Scenario and Workflow with Detailed Cavern #17944

Merged
merged 15 commits into from Mar 17, 2017

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Mar 15, 2017

  • Integrate detailed cavern description in 2023D12 scenario
  • Add 24434.0 relval workflow to test it
  • Correct exception message from DDG4Builder
  • Remove overlaps which were introduced by a detailed cavern inclusion

It is based on #17942

@kpedro88, @calabria, @pietverwilligen - FYI

Note: The Air mother volume changes and cable re-parenting were introduced in M2. Sensitive volumes are not affected.

Fixed here: Another note: there are serious overlaps present (unrelated to cavern description and file restructuring). Probably, the most offensive is 133.2 cm extrusion:

mf:ME0RingP extruded by: mf:ME0RingP/mfshield:ShieldingAntinomyLead_1_ME0_1 ovlp=133.2

screen shot 2017-03-15 at 14 58 29

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/ForwardCommonData
Geometry/MuonCommonData
SimG4Core/Geometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ptcox, @dgulhan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ianna
Copy link
Contributor Author

ianna commented Mar 15, 2017

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@ianna ianna changed the title 2023 d12 overlap fixes v1 2023 D12 Overlap Fixes Mar 15, 2017
@ianna
Copy link
Contributor Author

ianna commented Mar 15, 2017

It looks like it was a typo in the following commit: the width of ShieldingAntinomyLead_1_ME0 was changed from 15 cm to 148 cm. I guess, it should have been 14.8 cm.
64ce91a#diff-b218f83d63f4e7c62b854be6f6e7c449

@cmsbuild
Copy link
Contributor

Pull request #17944 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @davidlange6 can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Mar 17, 2017

@davidlange6 - I've removed the file in question. The rest is unchanged. We can wait to re-collect the signatures or you can accept it as is.

@ianna
Copy link
Contributor Author

ianna commented Mar 17, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18526/console Started: 2017/03/17 18:10

@ianna
Copy link
Contributor Author

ianna commented Mar 17, 2017

please test

@kpedro88
Copy link
Contributor

+1

@davidlange6 davidlange6 merged commit 698ba87 into cms-sw:master Mar 17, 2017
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants