New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023 Scenario and Workflow with Detailed Cavern #17944
Conversation
…-07-1100 2017dev scenario with improved cavern geometry imported from fluka v3.0.0.0
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
It looks like it was a typo in the following commit: the width of ShieldingAntinomyLead_1_ME0 was changed from 15 cm to 148 cm. I guess, it should have been 14.8 cm. |
Pull request #17944 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @davidlange6 can you please check and sign again. |
@davidlange6 - I've removed the file in question. The rest is unchanged. We can wait to re-collect the signatures or you can accept it as is. |
+1 |
The tests are being triggered in jenkins. |
please test |
+1 |
Comparison job queued. |
It is based on #17942
@kpedro88, @calabria, @pietverwilligen - FYI
Note: The Air mother volume changes and cable re-parenting were introduced in M2. Sensitive volumes are not affected.
Fixed here:
Another note: there are serious overlaps present (unrelated to cavern description and file restructuring). Probably, the most offensive is 133.2 cm extrusion: