Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Phase2-hgx73 Add a new scenario with TDR version for HGCal #17995

Merged
merged 4 commits into from Mar 23, 2017

Conversation

bsunanda
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
Configuration/StandardSequences
Geometry/CMSCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @franzoni, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @dgulhan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@boudoul
Copy link
Contributor

boudoul commented Mar 20, 2017

Dear @bsunanda , @kpedro88 presumably this file
https://github.com/cms-sw/cmssw/blob/master/Configuration/Geometry/python/dict2023Geometry.py , should be updated (and used) ?

@cmsbuild
Copy link
Contributor

Pull request #17995 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @franzoni, @kpedro88, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18563/console Started: 2017/03/20 18:25

@ianna
Copy link
Contributor

ianna commented Mar 20, 2017

+1

@kpedro88
Copy link
Contributor

@bsunanda should there also be a matrix workflow defined for the D13 scenario?

NB, this PR will have to be rebased/updated if #17970 is merged first, due to a change in the M2 geometry.

@kpedro88
Copy link
Contributor

@bsunanda I sent you bsunanda#11 with the workflow. I tested 10 events of ttbar (24834.0) and it runs fine, no unexpected errors or warnings.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #17995 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18574/console Started: 2017/03/20 21:24

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ianna
Copy link
Contributor

ianna commented Mar 20, 2017

+1

@cmsbuild
Copy link
Contributor

@fabozzi
Copy link
Contributor

fabozzi commented Mar 21, 2017

+1

@kpedro88
Copy link
Contributor

+1
(since this one seems ready to go and #17970 is not, we can merge this one first and that one will have to update accordingly)

@Dr15Jones
Copy link
Contributor

The newly added workflows are failing with the exception

----- Begin Fatal Exception 23-Mar-2017 21:19:18 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 2
   [1] Running path 'digi2raw_step'
   [2] Calling method for module HcalDigiToRaw/'hcalRawDataVME'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::SortedCollection<HcalTriggerPrimitiveDigi,edm::StrictWeakOrdering<HcalTriggerPrimitiveDigi> >
Looking for module label: simHcalTriggerPrimitiveDigis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

@kpedro88
Copy link
Contributor

@Dr15Jones where are you seeing that? The relval log for 24834.0 in CMSSW_9_1_X_2017-03-23-1100 looks fine to me. (I had also tested it privately before adding it in this PR...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants