bsunanda:Run2-alca76 Add a useful filter to estimate space requirement for IsoTrackProducer with selected HLT's #18001
Conversation
…r with selected HLT
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Calibration/HcalAlCaRecoProducers @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
@franzoni Please approve this |
| edm::LogWarning("HcalIsoTrack") << "Error! Can't get the product " | ||
| << triggerEvent_.label() ; | ||
| } else { | ||
| triggerEvent = *(triggerEventHandle.product()); |
There was a problem hiding this comment.
@bsunanda where are you using this triggerEvent?
There was a problem hiding this comment.
This I shall check
There was a problem hiding this comment.
If not useful can be taken care of later.
There was a problem hiding this comment.
Earlier when we tested TriggerResults we always used to check if TriggerEvent is present for the event. We shall double check this.
There was a problem hiding this comment.
indeed there is no reason for this object to be retrieved from the event, as you don't use it - please remove it.
| edm::LogInfo("HcalIsoTrack") << "Trigger[" << k << "] " << trigNames_[k] | ||
| << std::endl; | ||
| #ifdef EDM_ML_DEBUG | ||
| std::cout << "HcalIsoTrack: Trigger[" << k << "] " << trigNames_[k] |
There was a problem hiding this comment.
@bsunanda Is there any use of these cout statements now? There are few of them in this code. Although I think this ifdef won't let it print since it is defined without any initialisation. Is it false by default? Can you please confirm?
There was a problem hiding this comment.
They are useful in debugging - for normal operation they are protected by the EDM_ML_DEBUG flag. It is switched off for normal production
| IsoTracksProdFilter = cms.EDFilter("AlCaIsoTracksProducerFilter", | ||
| TriggerEventLabel = cms.InputTag("hltTriggerSummaryAOD","","HLT"), | ||
| TriggerResultLabel= cms.InputTag("TriggerResults","","HLT"), | ||
| Triggers = cms.vstring("HLT_IsoTrackHB","HLT_IsoTrackHE"), |
There was a problem hiding this comment.
@bsunanda Are these triggers part of 2017 HLT menu already? What rate has been agreed on? It would be good to have some pointers related to the proposal of these triggers.
There was a problem hiding this comment.
Yes they are. They are the calibration triggers using IsoTracks in HCAL
|
@bsunanda thanks for the answers. What is the efficiency of such filtering? How much reduction you got with application of this filter, may be you have checked it already with some 2016 data. As I can see these triggers were present in 2016 menu, although prescaled. |
|
@arunhep This one just selects the chosen HLT's. We are using it together with a producer with appropriate output request. We reported disk space requirement for this stream in a previous AlCaDb meeting. |
|
@bsunanda thanks. |
|
+1 |
cmsbuild
added
alca-pending
comparison-pending
orp-pending
pending-signatures
tests-pending
and removed
tests-approved
labels
|
@arunhep This one just selects the chosen HLT's. We are using it together with a producer with appropriate output request. We reported disk space requirement for this stream in a previous AlCaDb meeting. |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
@franzoni @arunhep @davidlange6 Can you approve and accept this PR now? |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
|
+1 |
No description provided.