Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase1 Geometry in Online #18027

Merged
merged 1 commit into from Mar 22, 2017
Merged

Phase1 Geometry in Online #18027

merged 1 commit into from Mar 22, 2017

Conversation

fioriNTU
Copy link
Contributor

switch to the new geometry in online

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fioriNTU for master.

It involves the following packages:

DQM/SiPixelPhase1Config

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @hdelanno this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@fioriNTU
Copy link
Contributor Author

Sorry, I forgot this fundamental change (I made a PR also in 90X #18028, donno if it is still possible to integrate)

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 22, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18620/console Started: 2017/03/22 11:56
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18622/console Started: 2017/03/22 12:01

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d5e9f5c into cms-sw:master Mar 22, 2017
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants