Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Python MassReplace* functions to FWCore #18081

Merged
merged 1 commit into from Apr 3, 2017

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Mar 24, 2017

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

Configuration/Applications
FWCore/ParameterSet
HLTrigger/Configuration
PhysicsTools/PatAlgos
RecoHI/HiEgammaAlgos

@perrotta, @smuzaffar, @Dr15Jones, @silviodonato, @fwyzard, @franzoni, @monttj, @Martin-Grunewald, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @gouskos, @rappoccio, @Martin-Grunewald, @ahinzmann, @geoff-smith, @mmarionncern, @imarches, @makortel, @acaudron, @jdolen, @ferencek, @mandrenguyen, @yetkinyilmaz, @wmtan, @nhanvtran, @gkasieczka, @jalimena, @schoef, @dgulhan, @jazzitup, @JyothsnaKomaragiri, @mverzett, @yenjie, @kurtejung, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@wddgit
Copy link
Contributor Author

wddgit commented Mar 24, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 24, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18691/console Started: 2017/03/25 01:01

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

-1

Tested at: 7219d1c

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
43c5e90
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18081/18691/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18081/18691/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18081/18691/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests AddOn

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-24-1100/src/Utilities/ReleaseScripts/scripts/read312RV_cfg.py : FAILED - time: date Sat Mar 25 03:08:04 2017-date Sat Mar 25 03:00:42 2017 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Sat Mar 25 03:08:53 2017-date Sat Mar 25 03:00:43 2017 s - exit: 23552
cmsRun /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Mar 25 03:08:53 2017-date Sat Mar 25 03:00:43 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Sat Mar 25 03:08:53 2017-date Sat Mar 25 03:00:43 2017 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun2016 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun2016_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Sat Mar 25 03:14:43 2017-date Sat Mar 25 03:05:26 2017 s - exit: 23552
cmsRun /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun2016.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Mar 25 03:14:43 2017-date Sat Mar 25 03:05:26 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun2016,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun2016 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun2016_DATA.root --fileout file:RelVal_Raw_GRun2016_DATA_HLT_RECO.root : FAILED - time: date Sat Mar 25 03:14:43 2017-date Sat Mar 25 03:05:26 2017 s - exit: 21504

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
43c5e90
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18081/18691/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18081/18691/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18081/18691/summary.html

There are some workflows for which there are errors in the baseline:
4.53 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18699/console Started: 2017/03/25 19:06

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+1
FWCore code that moves around (and gets a few updates)
No direct effect on Reco objects

@davidlange6 davidlange6 merged commit 309ec8c into cms-sw:master Apr 3, 2017
@wddgit wddgit deleted the moveMassReplaceFunctions branch August 2, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants