adding decays and first daugthers for bph studies #18086

alberto-sanchez · 2017-03-27T03:36:18Z

This will allow to store b-hadron decays and first daugthers of onia-like states, needed for BPH studies (signal or background). This will increase the size of the pruner list, which contains all important information for about 466 Bytes/Event (after the last modification), when measured with the ttbar relval sample

/RelValTTbar_13/CMSSW_9_0_0_pre4-PU25ns_90X_upgrade2017_realistic_v6-v1/GEN-SIM-RECO

this represent about 0.9% of the current MINIAODSIM size. Details of this addition/validation were shown in the xPOG forum: https://indico.cern.ch/event/626270/

cmsbuild · 2017-03-27T03:36:37Z

A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

perrotta · 2017-03-27T05:36:18Z

please test

cmsbuild · 2017-03-27T05:36:32Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18706/console Started: 2017/03/27 07:43

cmsbuild · 2017-03-27T06:43:47Z

+1
Tested at: ca7c3d5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18086/18706/summary.html

cmsbuild · 2017-03-27T06:43:49Z

Comparison job queued.

cmsbuild · 2017-03-27T07:53:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18086/18706/summary.html

arizzi · 2017-03-27T14:30:01Z

PhysicsTools/PatAlgos/python/slimming/prunedGenParticles_cfi.py

-        "keep abs(pdgId) == 443 || abs(pdgId) == 100443 || abs(pdgId) == 10441 || abs(pdgId) == 20443 || abs(pdgId) == 445 || abs(pdgId) == 30443",
-        "keep abs(pdgId) == 553 || abs(pdgId) == 100553 || abs(pdgId) == 200553 || abs(pdgId) == 10551 || abs(pdgId) == 20553 || abs(pdgId) == 555",
+# keep b and c hadrons for hadron-based jet flavour, and decays for BPH studies
+	"keep++ (400 < abs(pdgId) < 600) || (4000 < abs(pdgId) < 6000)",


didn't we agree to keep only first generation daughters? (given that packed Gen are anyhow available?)
How much the size increase changes if you change the above line to keep+ rather than keep++ ?

No, if I understood correctly we asked for keep++. Anyway I have tested and is required to have this, otherwise some hadrons like eta, rho, omega, pi0, K0, K0L, among other will be missing. I currently do not have the size from the relval sample, I am laughing jobs. But the count of pruner particles with keep++ increase by 16.5% in average, while for keep+, just about 13% in my test samples.

arizzi · 2017-03-27T17:43:55Z

mh, let's discuss this at XPOG tomorrow

…

On Mon, Mar 27, 2017 at 7:39 PM, Alberto Sanchez Hernandez < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In PhysicsTools/PatAlgos/python/slimming/prunedGenParticles_cfi.py <#18086 (comment)>: > @@ -20,12 +20,13 @@ "keep (4 <= abs(pdgId) <= 5)", # keep light-flavour quarks and gluons for parton-based jet flavour "keep (1 <= abs(pdgId) <= 3 || pdgId = 21) & (status = 2 || status = 11 || status = 71 || status = 72) && pt>5", -# keep b and c hadrons for hadron-based jet flavour - "keep (400 < abs(pdgId) < 600) || (4000 < abs(pdgId) < 6000)", -# keep onia states - "keep abs(pdgId) == 333", - "keep abs(pdgId) == 443 || abs(pdgId) == 100443 || abs(pdgId) == 10441 || abs(pdgId) == 20443 || abs(pdgId) == 445 || abs(pdgId) == 30443", - "keep abs(pdgId) == 553 || abs(pdgId) == 100553 || abs(pdgId) == 200553 || abs(pdgId) == 10551 || abs(pdgId) == 20553 || abs(pdgId) == 555", +# keep b and c hadrons for hadron-based jet flavour, and decays for BPH studies + "keep++ (400 < abs(pdgId) < 600) || (4000 < abs(pdgId) < 6000)", No, if I understood correctly we asked for keep++. Anyway I have tested and is required to have this, otherwise some hadrons like eta, rho, omega, pi0, K0, K0L, among other will be missing. I currently do not have the size from the relval sample, I am laughing jobs. But the count of pruner particles with keep++ increase by 16.5% in average, while for keep+, just about 13% in my test samples. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#18086 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEyili43jX3DRw6r8Cs33ftaHNiA93fUks5rp_RCgaJpZM4Mpwad> .

alberto-sanchez · 2017-03-27T17:52:56Z

@arizzi, sure!. I have already put as part of my report.

arizzi · 2017-03-28T15:08:31Z

following the XPOG discussion, we would need to remove the status 1 added by this change so I'd move higher in the config B phys following this logic
"drop *", # this is the default
"++keep abs(pdgId) == 11 || abs(pdgId) == 13 || abs(pdgId) == 15", # keep leptons, with history
"drop status == 2", # drop the shower part of the history
"keep++ (400 < abs(pdgId) < 600) || (4000 < abs(pdgId) < 6000)",
"drop status == 1", # drop the status=1 from BPH
"keep abs(pdgId) == 11 || abs(pdgId) == 13 || abs(pdgId) == 15", # keep leptons (also status1)
"keep abs(pdgId) == 12 || abs(pdgId) == 14 || abs(pdgId) == 16", # keep neutrinos

cmsbuild · 2017-03-29T20:28:06Z

Pull request #18086 was updated. @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please check and sign again.

alberto-sanchez · 2017-03-29T20:30:31Z

@arizzi, reworking the logic as you suggest, reduce the amount of pruners and issues with lifetime determination are also resolved by adding the first daughters.

arizzi · 2017-03-30T05:56:14Z

What are the new size increase numbers?

alberto-sanchez · 2017-03-30T16:09:21Z

@arizzi. I already update the description with the new numbers. It is about 466 Bytes/Event and which represents an increase of 0.9% in the total miniaod.

slava77 · 2017-03-31T05:53:28Z

@cmsbuild please test

cmsbuild · 2017-03-31T05:53:42Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18816/console Started: 2017/03/31 08:43

cmsbuild · 2017-03-31T08:07:58Z

+1
Tested at: 276af61
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18086/18816/summary.html

cmsbuild · 2017-03-31T08:08:00Z

Comparison job queued.

arizzi · 2017-03-31T08:47:24Z

I think we can survive with this size increase without further optimization (such as keeping only one daughter or stuff like that) given that ttbar is anyhow a biased sample (there are always 2 B and many D) so the relative increase in average samples is smaller/

…

On Fri, Mar 31, 2017 at 10:08 AM, cmsbuild ***@***.***> wrote: +1 Tested at: 276af61 <276af61> https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull- request-integration/PR-18086/18816/summary.html — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18086 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEyilnCs5dMaGtt6fIGF5MAqR66VfY1Hks5rrLRggaJpZM4Mpwad> .

cmsbuild · 2017-03-31T10:55:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18086/18816/summary.html

slava77 · 2017-04-03T17:16:08Z

+1

for #18086 276af61

updates to prunedGenParticles_cfi.py are in line with the PR description.
jenkins tests pass and comparisons with baseline show no differences
local test with 2K events of 910pre1 ttbar PU35 2017 wflow with PAT shows about 0.9% increase in size of prunedGenParticles

davidlange6 · 2017-04-05T07:20:54Z

PhysicsTools/PatAlgos/python/slimming/prunedGenParticles_cfi.py

        "drop   status == 2",                                              # drop the shower part of the history
+        "keep++ (400 < abs(pdgId) < 600) || (4000 < abs(pdgId) < 6000)",   # keep decays for BPH studies


hi @alberto-sanchez - for my information what does keep vs keep+ vs keep++ mean in this syntax?

arizzi · 2017-04-05T07:25:06Z

k++ = recursive keep daughters k+ = just first generation daughters

…

On Wed, Apr 5, 2017 at 9:20 AM, David Lange ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In PhysicsTools/PatAlgos/python/slimming/prunedGenParticles_cfi.py <#18086 (comment)>: > "drop status == 2", # drop the shower part of the history + "keep++ (400 < abs(pdgId) < 600) || (4000 < abs(pdgId) < 6000)", # keep decays for BPH studies hi @alberto-sanchez <https://github.com/alberto-sanchez> - for my information what does keep vs keep+ vs keep++ mean in this syntax? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18086 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEyilg-2obyGRzciDCuE396FT31x3E6Nks5rs0DXgaJpZM4Mpwad> .

davidlange6 · 2017-04-05T07:28:56Z

+1 but gaack

…

On Apr 5, 2017, at 9:25 AM, arizzi ***@***.***> wrote: k++ = recursive keep daughters k+ = just first generation daughters On Wed, Apr 5, 2017 at 9:20 AM, David Lange ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In PhysicsTools/PatAlgos/python/slimming/prunedGenParticles_cfi.py > <#18086 (comment)>: > > > "drop status == 2", # drop the shower part of the history > + "keep++ (400 < abs(pdgId) < 600) || (4000 < abs(pdgId) < 6000)", # keep decays for BPH studies > > hi @alberto-sanchez <https://github.com/alberto-sanchez> - for my > information what does keep vs keep+ vs keep++ mean in this syntax? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#18086 (review)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AEyilg-2obyGRzciDCuE396FT31x3E6Nks5rs0DXgaJpZM4Mpwad> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

adding decays and first daugthers for bph studies

ca7c3d5

cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 27, 2017

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 27, 2017

cmsbuild added tests-started and removed tests-pending labels Mar 27, 2017

cmsbuild added tests-approved and removed tests-started labels Mar 27, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 27, 2017

arizzi reviewed Mar 27, 2017

View reviewed changes

reworking the logic, in order to reduce the amount of pruners

276af61

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Mar 29, 2017

cmsbuild added tests-started and removed tests-pending labels Mar 31, 2017

cmsbuild added tests-approved and removed tests-started labels Mar 31, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 31, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 3, 2017

davidlange6 reviewed Apr 5, 2017

View reviewed changes

davidlange6 merged commit d3aa856 into cms-sw:master Apr 5, 2017

cmsbuild added orp-approved and removed orp-pending labels Apr 5, 2017

alberto-sanchez deleted the mc-for-bph branch April 18, 2017 00:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding decays and first daugthers for bph studies #18086

adding decays and first daugthers for bph studies #18086

alberto-sanchez commented Mar 27, 2017 •

edited

cmsbuild commented Mar 27, 2017

perrotta commented Mar 27, 2017

cmsbuild commented Mar 27, 2017 •

edited

cmsbuild commented Mar 27, 2017

cmsbuild commented Mar 27, 2017

cmsbuild commented Mar 27, 2017

arizzi Mar 27, 2017

alberto-sanchez Mar 27, 2017

arizzi commented Mar 27, 2017 via email

alberto-sanchez commented Mar 27, 2017

arizzi commented Mar 28, 2017

cmsbuild commented Mar 29, 2017

alberto-sanchez commented Mar 29, 2017

arizzi commented Mar 30, 2017

alberto-sanchez commented Mar 30, 2017

slava77 commented Mar 31, 2017

cmsbuild commented Mar 31, 2017 •

edited

cmsbuild commented Mar 31, 2017

cmsbuild commented Mar 31, 2017

arizzi commented Mar 31, 2017 via email

cmsbuild commented Mar 31, 2017

slava77 commented Apr 3, 2017

davidlange6 Apr 5, 2017

arizzi commented Apr 5, 2017 via email

davidlange6 commented Apr 5, 2017 via email

		"drop status == 2", # drop the shower part of the history
		"keep++ (400 < abs(pdgId) < 600) \|\| (4000 < abs(pdgId) < 6000)", # keep decays for BPH studies

adding decays and first daugthers for bph studies #18086

adding decays and first daugthers for bph studies #18086

Conversation

alberto-sanchez commented Mar 27, 2017 • edited

cmsbuild commented Mar 27, 2017

perrotta commented Mar 27, 2017

cmsbuild commented Mar 27, 2017 • edited

cmsbuild commented Mar 27, 2017

cmsbuild commented Mar 27, 2017

cmsbuild commented Mar 27, 2017

arizzi Mar 27, 2017

Choose a reason for hiding this comment

alberto-sanchez Mar 27, 2017

Choose a reason for hiding this comment

arizzi commented Mar 27, 2017 via email

alberto-sanchez commented Mar 27, 2017

arizzi commented Mar 28, 2017

cmsbuild commented Mar 29, 2017

alberto-sanchez commented Mar 29, 2017

arizzi commented Mar 30, 2017

alberto-sanchez commented Mar 30, 2017

slava77 commented Mar 31, 2017

cmsbuild commented Mar 31, 2017 • edited

cmsbuild commented Mar 31, 2017

cmsbuild commented Mar 31, 2017

arizzi commented Mar 31, 2017 via email

cmsbuild commented Mar 31, 2017

slava77 commented Apr 3, 2017

davidlange6 Apr 5, 2017

Choose a reason for hiding this comment

arizzi commented Apr 5, 2017 via email

davidlange6 commented Apr 5, 2017 via email

alberto-sanchez commented Mar 27, 2017 •

edited

cmsbuild commented Mar 27, 2017 •

edited

cmsbuild commented Mar 31, 2017 •

edited