New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEM21 geometry #1809
GEM21 geometry #1809
Conversation
ianna
commented
Dec 13, 2013
- GE21 short chambers are fully implemented, readout board is still missing
- GE21 long chambers need sensitive volumes and readout board
A new Pull Request was created by @ianna for CMSSW_7_0_X. GEM21 geometry It involves the following packages: Geometry/MuonCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks. |
'Geometry/MuonCommonData/data/v2/rpcf.xml', | ||
'Geometry/MuonCommonData/data/v4/gemf.xml', | ||
'Geometry/MuonCommonData/data/v6/gemf.xml', | ||
'Geometry/MuonCommonData/data/gem21.xml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo? Shouldn't this be data/v6/gem21.xml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, I'll fix it on Monday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From now on I'm "Eagle Eye Giulio"...
Pull request #1809 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again. |
@dildick - please, take this branch. Thanks. |
<rSolid name="RED4"/> | ||
<rMaterial name="materials:M_RPC_Gas"/> | ||
</LogicalPart> | ||
</LogicalPartSection> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not convinced why this RPC part should be present in the GEM geometry definition. Can we leave it out in all prototypes without harm?
Pull request #1809 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again. |
@dildick - please, check. Thanks! |
Pull request #1809 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again. |
@dildick - Please, try it now. Thanks. |
@ianna The GE2/1 eta partitions are now found by the geometry builder, but they are assigned the same detIds as their GE1/1 counterparts. (Station number is put to 1) A minor change needs to be done in the numbering XML file. You can use this recipe to debug it. (It already contains all your additions) cmsrel CMSSW_6_2_X_SLHC_2013-12-09-1400 cmsRun Geometry/GEMGeometry/test/testGEMGeometry_cfg.py |
Pull request #1809 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @ktf can you please check and sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it? |
Geometry updates -- GEM21 geometry
I ran the geometry tester on this PR. Can you fix the XML file? Thanks. [lxplus443] /afs/cern.ch/user/d/dildick/work/GEM/testForYana/CMSSW_7_0_X_2013-12-18-0200/src/Geometry/GEMGeometry/test > !cmsR |
@dildick - ok, I've added the constant, but I'll need to resubmit it in a different branch. |