Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[90X] Fix muon alignment converter #18098

Merged

Conversation

ghellwig
Copy link

backport of #18097

Fixes bugs in muon alignment code used for providing muon alignment constants.
Adds also a unit test to prevent such a silent introduction of bugs in the future.
Migrated the respective module to an edm::one module.

Attn.: @lpernie

@ghellwig
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18736/console Started: 2017/03/27 18:38

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_9_0_X.

It involves the following packages:

Alignment/CommonAlignment
Alignment/MuonAlignment
Alignment/MuonAlignmentAlgorithms

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @abbiendi, @jhgoh, @tocheng, @tlampen, @mschrode, @mmusich, @trocino this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ghellwig
Copy link
Author

type bugfix

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #18098 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@ghellwig
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18757/console Started: 2017/03/28 15:05

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@arunhep
Copy link
Contributor

arunhep commented Mar 28, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bf6bdc3 into cms-sw:CMSSW_9_0_X Apr 3, 2017
@ghellwig ghellwig deleted the fix-muon-alignment-converter_90X branch May 2, 2017 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants