ME0Segment update for muon tdr samples #18127

nickmccoll · 2017-03-29T22:42:03Z

Three changes here:

Add the segment DPhi to the ME0Segments
This will be used in global reconstruction and in the trigger...it is better to calculate it once correctly. Incidentally, the ME0Segment size should be smaller now since we were unnecessarily keeping other variables with double precision. I added the computer as a static function that takes Points/Vectors as inputs. This is for matching to pixel tracks to segments, so that one can use the projected track's properties and get the proper Dphi.
Add central BX association
We have required that the ME0Segment is associated to the central BX in all studies, but did not apply it on the ME0Segment producing stage. However, these segments will be used a few times in the global muon reconstruction, so we thought it is best to filter out the bad segments here.
Default segment parameters
The parameters have been updated to match the baseline TDR granularity: 8 eta partitions/384 strips

++ one bug fix:
A change in the ME0Chamber geometry code:
The layer() functions were not working correctly...they iterated over layers but checked eta partition numbers.

…tputted as float

…gments

…strips

cmsbuild · 2017-03-29T22:42:21Z

A new Pull Request was created by @nickmccoll (Nick McColl) for master.

It involves the following packages:

DataFormats/GEMRecHit
Geometry/GEMGeometry
RecoLocalMuon/GEMSegment

@perrotta, @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @bellan, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @battibass, @trocino this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

ianna · 2017-03-30T05:51:29Z

DataFormats/GEMRecHit/BuildFile.xml

@@ -4,6 +4,8 @@

 <use   name="DataFormats/GeometryVector"/>
 <use   name="DataFormats/CSCRecHit"/>
+<use   name="Geometry/GEMGeometry"/>


@nickmccoll - DataFormats cannot depend on Geometry

ianna · 2017-03-30T05:52:49Z

DataFormats/GEMRecHit/src/ME0Segment.cc

@@ -5,6 +5,9 @@
 */
 #include "FWCore/MessageLogger/interface/MessageLogger.h"
 #include "DataFormats/GEMRecHit/interface/ME0Segment.h"


@nickmccoll - I think, the place for this class is in Geometry/GEMGeometry

ianna · 2017-03-30T05:57:03Z

DataFormats/GEMRecHit/BuildFile.xml

@@ -4,6 +4,8 @@

 <use   name="DataFormats/GeometryVector"/>
 <use   name="DataFormats/CSCRecHit"/>
+<use   name="Geometry/GEMGeometry"/>
+<use   name="root"/>


@nickmccoll - also, brining in root dependency here is not a good idea

ianna · 2017-03-30T05:58:56Z

DataFormats/GEMRecHit/src/ME0Segment.cc

@@ -5,6 +5,9 @@
 */
 #include "FWCore/MessageLogger/interface/MessageLogger.h"
 #include "DataFormats/GEMRecHit/interface/ME0Segment.h"
+#include "Geometry/GEMGeometry/interface/ME0Chamber.h"
+#include "Geometry/GEMGeometry/interface/ME0Layer.h"
+#include <TVector2.h>


@nickmccoll - isn't there a CMS equivalent for it in DataFormats/GeometryVector?

ianna · 2017-03-30T06:03:58Z

DataFormats/GEMRecHit/interface/ME0Segment.h

-
+
+  float deltaPhi() const { return theDeltaPhi; }
+  static float computeDeltaPhi(const ME0Chamber * chamber, const LocalPoint& position, const LocalVector& direction );


@nickmccoll - this function does not belong in ME0Segment, nor in DataFormats. I can see it is used in a plugin ME0SegmentAlgorithm. Shouldn't it be moved there? @slava77 - please, suggest a better place for it to avoid circular dependency.

I can put it in the ME0SegmentAlgorithm, if there is no problem that RecoMuonProducer depends on it. Otherwise I can duplicate the code and place it both in the global muon reconstruction and in the segment algorithm.

@nickmccoll - which class represents RecoMuonProducer? Duplicating the code is not a good idea, nor introducing dependency on a plugin.

@ianna It would be used under: RecoMuon/GlobalMuonProducer/src/GlobalMuonProducer.h and the related classes when building RecoMuons. Technically it should also be used in ME0SegmentMatcher.

I couldn't really think of a good place to put this function, and now that I think about it the ME0Segment isn't a very good place for it at all. I am open to any suggestion!

Thanks!

@nickmccoll - would RecoMuon/GlobalTrackingTools be a good place for it?

I believe the bending angle is something strictly related to the segment, then later to the matching and the muon ID. so the function can go into the algorithms that build the segment. why do you think it is not a good place?

@ianna If there is no problem with ME0SegmentAlgorithm depending on it, then I think it is fine.

@calabria We also need to calculate it for projected pixel tracks as we compare projected and segment bending angles when matching.

@nickmccoll Usually Reco depends on LocalReco and not vice versa. How about placing it in Geometry/GEMGeometry?

@ianna That is a good idea, it naturally fits in as a ME0Chamber function. I updated the PR, and there are no new dependencies!

ianna · 2017-03-31T05:27:40Z

please test

cmsbuild · 2017-03-31T05:27:59Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18813/console Started: 2017/03/31 08:25

cmsbuild · 2017-03-31T09:42:30Z

-1

Tested at: 548e308

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18127/18813/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test runtestRecoEgammaElectronIdentification had ERRORS
---> test TestJetMETCorrectionsModulesJetResolutionObject had ERRORS
---> test testRecoMETMETProducers had ERRORS

cmsbuild · 2017-03-31T09:42:32Z

Comparison job queued.

cmsbuild · 2017-03-31T12:08:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18127/18813/summary.html

nickmccoll · 2017-03-31T14:13:29Z

Looking at the unit tests, I see this as a cause of failure:

pickRelValInputFiles WARNING : No RelVal file(s) found at all in datasets '/RelValTTbar_13/CMSSW_7_4_0_pre6-PU50ns_MCRUN2_74_V0-v*/GEN-SIM-RECO*' on SE 'T2_CH_CERN'

kpedro88 · 2017-03-31T14:20:56Z

@smuzaffar is this a file deletion issue, or just a temporary interruption?

cmsbuild · 2017-04-05T12:22:35Z

-1

Tested at: d74aaa1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18127/18932/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

cmsbuild · 2017-04-05T12:22:37Z

Comparison job queued.

perrotta · 2017-04-05T13:02:04Z

The error in the unit test is still there [1], but I can hardly believe it is caused by this PR

[1]

cmsRun /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/RecoMET/METProducers/test/recoMET_caloMet_cfg.py
05-Apr-2017 12:17:55 CEST Initiating request to open file file:ttbarForMetTests.root
----- Begin Fatal Exception 05-Apr-2017 12:17:55 CEST-----------------------
An exception of category 'FileOpenError' occurred while
[0] Constructing the EventProcessor
[1] Constructing input source of type PoolSource
[2] Calling RootFileSequenceBase::initTheFile()
[3] Calling StorageFactory::open()
[4] Calling File::sysopen()
Exception Message:
Failed to open the file 'ttbarForMetTests.root'
Additional Info:
[a] Input file file:ttbarForMetTests.root could not be opened.
[b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
die 'Failure using recoMET_caloMet_cfg.py' 84
echo Failure using recoMET_caloMet_cfg.py: status 84
Failure using recoMET_caloMet_cfg.py: status 84
exit 84
status = 21504

---> test testRecoMETMETProducers had ERRORS

^^^^ End Test testRecoMETMETProducers ^^^^

slava77 · 2017-04-05T13:10:13Z

try to rerun. It may go away. (the error has something to do with this ttbarForMetTests.root written to a common test area which may be also used in parallel by another unit test which cleans up the directory

…

On 4/5/17 3:02 PM, perrotta wrote: The error in the unit test is still there [1], but I can hardly believe it is caused by this PR [1] * cmsRun /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/RecoMET/METProducers/test/recoMET_caloMet_cfg.py 05-Apr-2017 12:17:55 CEST Initiating request to open file file:ttbarForMetTests.root ----- Begin Fatal Exception 05-Apr-2017 12:17:55 CEST----------------------- An exception of category 'FileOpenError' occurred while [0] Constructing the EventProcessor [1] Constructing input source of type PoolSource [2] Calling RootFileSequenceBase::initTheFile() [3] Calling StorageFactory::open() [4] Calling File::sysopen() Exception Message: Failed to open the file 'ttbarForMetTests.root' Additional Info: [a] Input file file:ttbarForMetTests.root could not be opened. [b] open() failed with system error 'No such file or directory' (error code 2) ----- End Fatal Exception ------------------------------------------------- * die 'Failure using recoMET_caloMet_cfg.py' 84 * echo Failure using recoMET_caloMet_cfg.py: status 84 Failure using recoMET_caloMet_cfg.py: status 84 * exit 84 status = 21504 ---> test testRecoMETMETProducers had ERRORS ^^^^ End Test testRecoMETMETProducers ^^^^ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18127 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbn_cZ6bKqzbIn0-b24BtMpbkRMvCks5rs5DMgaJpZM4MtpeH>.

perrotta · 2017-04-05T13:24:13Z

please test
(third attempt...)

cmsbuild · 2017-04-05T13:24:33Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18943/console Started: 2017/04/05 15:25

kpedro88 · 2017-04-05T13:24:56Z

personally I think a test with so many spurious failures should be restructured or deleted...

cmsbuild · 2017-04-05T17:05:21Z

+1
Tested at: d74aaa1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18127/18943/summary.html

cmsbuild · 2017-04-05T17:05:24Z

Comparison job queued.

cmsbuild · 2017-04-06T00:08:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18127/18943/summary.html

davidlange6 · 2017-04-06T07:55:18Z

+1

nickmccoll added 5 commits March 29, 2017 13:18

Moved the time info to float since it is ~integer data and is even ou…

3c4c2d8

…tputted as float

Store deltaPhi variable in ME0Segment

ef259a5

ME0Chamber layer functions had a bug, were checking partition numbers

d9de5c3

Add parameter to require coincidence with central BX when building se…

fed5cc4

…gments

Change parameter defaults to baseline geometry: 8 eta partitions/384 …

c2365ec

…strips

cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 29, 2017

cmsbuild added comparison-pending geometry-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Mar 29, 2017

ianna suggested changes Mar 30, 2017

View reviewed changes

Moved the deltaPhi function to ME0Chamebr

548e308

nickmccoll mentioned this pull request Mar 30, 2017

ME0 pseudo digitizer update #18113

Merged

cmsbuild added tests-started and removed tests-pending labels Mar 31, 2017

cmsbuild added tests-rejected and removed tests-started labels Mar 31, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 31, 2017

cmsbuild added comparison-pending tests-pending tests-started and removed comparison-notrun tests-rejected tests-pending labels Apr 5, 2017

cmsbuild added tests-rejected and removed tests-started labels Apr 5, 2017

cmsbuild added tests-pending and removed tests-rejected labels Apr 5, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 5, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 5, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 6, 2017

cmsbuild added orp-approved and removed orp-pending labels Apr 6, 2017

cmsbuild merged commit aba61af into cms-sw:master Apr 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ME0Segment update for muon tdr samples #18127

ME0Segment update for muon tdr samples #18127

nickmccoll commented Mar 29, 2017

cmsbuild commented Mar 29, 2017

ianna Mar 30, 2017

ianna Mar 30, 2017

ianna Mar 30, 2017

ianna Mar 30, 2017

ianna Mar 30, 2017

nickmccoll Mar 30, 2017

ianna Mar 30, 2017

nickmccoll Mar 30, 2017

ianna Mar 30, 2017

calabria Mar 30, 2017

nickmccoll Mar 30, 2017

ianna Mar 30, 2017

nickmccoll Mar 30, 2017

ianna commented Mar 31, 2017

cmsbuild commented Mar 31, 2017 •

edited

cmsbuild commented Mar 31, 2017

cmsbuild commented Mar 31, 2017

cmsbuild commented Mar 31, 2017

nickmccoll commented Mar 31, 2017

kpedro88 commented Mar 31, 2017

cmsbuild commented Apr 5, 2017

cmsbuild commented Apr 5, 2017

perrotta commented Apr 5, 2017

slava77 commented Apr 5, 2017 via email

perrotta commented Apr 5, 2017

cmsbuild commented Apr 5, 2017 •

edited

kpedro88 commented Apr 5, 2017

cmsbuild commented Apr 5, 2017

cmsbuild commented Apr 5, 2017

cmsbuild commented Apr 6, 2017

davidlange6 commented Apr 6, 2017



		float deltaPhi() const { return theDeltaPhi; }
		static float computeDeltaPhi(const ME0Chamber * chamber, const LocalPoint& position, const LocalVector& direction );

ME0Segment update for muon tdr samples #18127

ME0Segment update for muon tdr samples #18127

Conversation

nickmccoll commented Mar 29, 2017

cmsbuild commented Mar 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ianna commented Mar 31, 2017

cmsbuild commented Mar 31, 2017 • edited

cmsbuild commented Mar 31, 2017

cmsbuild commented Mar 31, 2017

cmsbuild commented Mar 31, 2017

nickmccoll commented Mar 31, 2017

kpedro88 commented Mar 31, 2017

cmsbuild commented Apr 5, 2017

cmsbuild commented Apr 5, 2017

perrotta commented Apr 5, 2017

slava77 commented Apr 5, 2017 via email

perrotta commented Apr 5, 2017

cmsbuild commented Apr 5, 2017 • edited

kpedro88 commented Apr 5, 2017

cmsbuild commented Apr 5, 2017

cmsbuild commented Apr 5, 2017

cmsbuild commented Apr 6, 2017

davidlange6 commented Apr 6, 2017

cmsbuild commented Mar 31, 2017 •

edited

cmsbuild commented Apr 5, 2017 •

edited