Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry xm lparser #18188

Merged
merged 2 commits into from Apr 6, 2017
Merged

Geometry xm lparser #18188

merged 2 commits into from Apr 6, 2017

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Apr 3, 2017

Updating the treatment of APEs in:
Alignment/MuonAlignment/python/geometryXMLparser.py

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

A new Pull Request was created by @lpernie (Luca) for master.

It involves the following packages:

Alignment/MuonAlignment

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @abbiendi, @jhgoh, @tocheng, @mschrode, @trocino this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ghellwig
Copy link

ghellwig commented Apr 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18914/console Started: 2017/04/04 17:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

@ghellwig
Copy link

ghellwig commented Apr 5, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@lpernie
Copy link
Contributor Author

lpernie commented Apr 5, 2017

Hi @ghellwig ,
this PR will be active in 91X right? Should I do a PR also in 901 for back porting?
Thanks.

@ghellwig
Copy link

ghellwig commented Apr 5, 2017

@lpernie you can make a PR in 90X, of course
Since, it's rather trivial we might get it in for the next release. Not sure, if there will be another 90X release beyond 901, though.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Apr 6, 2017
@cmsbuild cmsbuild merged commit bfcf737 into cms-sw:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants