Add virtual dtors for MakeProvenanceReader & ExpressionElementFinderBase #18190
Conversation
CMSSW GCC 7.0.1 builds now follows jemalloc (dev branch) and also has a
new TCMalloc. Both of these have C++14 sized deallocation feature
enabled. This means that if possible operator delete will be called with
size argument, which will help allocator to reduce the time to free the
object. E.g. this is not possible for incomplete types which size is
unknown at a time.
GCC 7.0.1 builds contain an additional build of jemalloc
(jemalloc-debug) which contains extra asserts and checks for developers.
It helped to find two places were operate delete is called using base
class type instead of actual type. E.g., this means that wrong size (8
bytes) were passed to operator delete instead of actual type (16 bytes).
This seems to be undefined behavior in C++14. From [expr.delete] (5.3.5
Delete):
In the first alternative (delete object), if the static type of the
object to be deleted is different from its dynamic type, the static type
shall be a base class of the dynamic type of the object to be deleted
and the static type shall have a virtual destructor or the behavior is
undefined.
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for master. It involves the following packages: CommonTools/Utils @perrotta, @smuzaffar, @Dr15Jones, @monttj, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
More details are available in commit notes, which are not showed on GitHub. It was debugged using |
|
Please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
core-approved
tests-started
and removed
core-pending
tests-pending
labels
|
Comparison job queued. |
|
+1 |
CMSSW GCC 7.0.1 builds now follows jemalloc (dev branch) and also has a
new TCMalloc. Both of these have C++14 sized deallocation feature
enabled. This means that if possible operator delete will be called with
size argument, which will help allocator to reduce the time to free the
object. E.g. this is not possible for incomplete types which size is
unknown at a time.
GCC 7.0.1 builds contain an additional build of jemalloc
(jemalloc-debug) which contains extra asserts and checks for developers.
It helped to find two places were operate delete is called using base
class type instead of actual type. E.g., this means that wrong size (8
bytes) were passed to operator delete instead of actual type (16 bytes).
This seems to be undefined behavior in C++14. From [expr.delete] (5.3.5
Delete):
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch