New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update legacy modules in SiStripTools, L1TCalorimeter, DQM #18195
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: DPGAnalysis/SiStripTools @monttj, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 The changes looks fine to me. |
+1 |
Followup to #18153, fixing more modules. attn: @Dr15Jones
@dmitrijus, it seemed straightforward to move
DQMMessageLogger
andAlcaBeamMonitor
to theDQMEDAnalyzer
stream framework. If this is inappropriate for a non-obvious reason, please let me know and I'll remove those commits. (In that case, I suppose those modules would have to becomeone
analyzers.)