Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update legacy modules in SiStripTools, L1TCalorimeter, DQM #18195

Merged
merged 6 commits into from Apr 6, 2017

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Apr 4, 2017

Followup to #18153, fixing more modules. attn: @Dr15Jones

@dmitrijus, it seemed straightforward to move DQMMessageLogger and AlcaBeamMonitor to the DQMEDAnalyzer stream framework. If this is inappropriate for a non-obvious reason, please let me know and I'll remove those commits. (In that case, I suppose those modules would have to become one analyzers.)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

DPGAnalysis/SiStripTools
DQM/BeamMonitor
DQM/DTMonitorModule
DQMServices/Components
L1Trigger/L1TCalorimeter

@monttj, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic, @kreczko, @Martin-Grunewald, @ebrondol, @threus, @venturia this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor Author

kpedro88 commented Apr 4, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18911/console Started: 2017/04/04 16:20

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

@dmitrijus
Copy link
Contributor

+1
thanks a lot!

The changes looks fine to me.
I do wonder DQM haven't migrated these two module ourselves many years ago... :(

@monttj
Copy link
Contributor

monttj commented Apr 6, 2017

+1

@davidlange6 davidlange6 merged commit 119f45b into cms-sw:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants