CTPPS: diamond DQM

[forthommel]

This PR introduces a new DQM source for the CTPPS diamond detector output harvesting.
In addition, for the purpose of this code several objects were introduced/modified:

• the totemDQM module is renamed to ctppsDQM (extension to other objects beside the silicon strips) and its sequence now also embeds the ctppsDiamondDQMSource module
• a new test is introduced for the diamond DQM (DQM/CTPPS/test/diamond_dqm_test_cfg.py)
• the HPTDCErrorFlags object is converted from a struct to a class with const'ed getters
• the diamond detectors' RecHits producer is modified to skip all digis with a channel identifier above the physical range ; all channels outside this range are considered as 'clocks' used for the monitoring of HPTDCs performance.

[cmsbuild]

A new Pull Request was created by @forthommel (Laurent Forthomme) for master.

It involves the following packages:

DQM/CTPPS
DQMOffline/Configuration
DataFormats/CTPPSDigi
RecoCTPPS/TotemRPLocal

@perrotta, @civanch, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18921/console Started: 2017/04/04 23:01

[cmsbuild]

+1
Tested at: 02bb697
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18198/18921/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18198/18921/summary.html

[cmsbuild]

Pull request #18198 was updated. @perrotta, @civanch, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

[nminafra]

@davidlange6 I've update the code to use static const for all the values related to the structure of the detector.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19186/console Started: 2017/04/14 20:24

[cmsbuild]

+1
Tested at: ead34f2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18198/19186/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18198/19186/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3258 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1818576
• DQMHistoTests: Total failures: 60129
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1758274
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[civanch]

+1

[slava77]

+1

for #18198 ead34f2

• updates since last reco signoff affected only non-reco code DQM/CTPPS/plugins/CTPPSDiamondDQMSource.cc

[davidlange6]

hi @forthommel @dmitrijus - i failed to realize this PR adds up 25MB per thread of histograms. Is that expected and agreed by DQM?

[dmitrijus]

Hi @davidlange6, a bit bigger than I expected. Thank your bringing this up.
Are those 25 megs really necessary? It seems a way too much - maybe it make sense to reduce resolution (bins) on 2d histograms?

[davidlange6]

and I should have added it is in addition to 11MB of CTPPSPixelDQMSource

…

On May 31, 2017, at 5:03 PM, Dmitrijus ***@***.***> wrote: Hi @davidlange6, a bit bigger than I expected. Thank your bringing this up. Are those 25 megs really necessary? It seems a way too much - maybe it make sense to reduce resolution (bins) on 2d histograms? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.