Removed #includes to TrackerTopology.h in DataFormats/GeometrySurface #18211

Teemperor · 2017-04-05T09:58:58Z

These includes cause a layering violation because GeometryCommonDetAlgo
in turn already depends on DataFormats/GeometrySurface.

cmsbuild · 2017-04-05T09:59:15Z

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

DataFormats/SiPixelDetId

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @ebrondol, @VinInn this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

civanch · 2017-04-05T10:18:08Z

please test

cmsbuild · 2017-04-05T10:18:23Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18935/console Started: 2017/04/05 12:20

cmsbuild · 2017-04-05T11:08:21Z

-1

Tested at: 7f28800

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
09ca96d
52ee4d0
d3aa856
6392f47
fcd293d
9819399
c75f9f3
b6eda34
62344a9
06d1fe3
03c43df
e97d88d
c7ced6a
66153ad
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18211/18935/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18211/18935/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18211/18935/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/DQMServices/Core/bin/MergeFile.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/DQMServices/Core/test/DQMTestStandaloneBuildOfDQMStore.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/DQMServices/Core/test/DQMFastMatchTest.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/DQMServices/Core/test/DQMQualityTestsExample.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/SLHCUpgradeSimulations/Geometry/src/PrintGeomMatInfo.cc: In member function 'void PrintGeomMatInfo::dumpSummary(std::ostream&)':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/SLHCUpgradeSimulations/Geometry/src/PrintGeomMatInfo.cc:174:11: error: 'G4PhysicalVolumeStore' does not name a type
     const G4PhysicalVolumeStore * pvs = G4PhysicalVolumeStore::GetInstance();
           ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/SLHCUpgradeSimulations/Geometry/src/PrintGeomMatInfo.cc:175:50: error: 'pvs' was not declared in this scope
     out << " Number of G4VPhysicalVolume's: " << pvs->size() << std::endl;
                                                  ^

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/CondCore/Utilities/plugins/BasicP_PayloadInspector.cc 
>> Compiling LCG dictionary: tmp/slc6_amd64_gcc530/src/CondCore/Utilities/src/CondCoreUtilities/a/CondCoreUtilities_xr.cc
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/CondCore/CondDB/plugins/RelationalAuthenticationService.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/CondCore/CondDB/plugins/CondDBPyWrappers.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/FastSimulation/CaloGeometryTools/src/CrystalPad.cc:1:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/FastSimulation/CaloGeometryTools/interface/CrystalPad.h:26:49: error: use of undeclared identifier 'CLHEP'
  CrystalPad(unsigned number, const std::vector& corners);
                                                ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-04-1100/src/FastSimulation/CaloGeometryTools/interface/CrystalPad.h:48:21: error: use of undeclared identifier 'CLHEP'
  bool inside(const CLHEP::Hep2Vector & point,bool debug=false) const;
                    ^

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
09ca96d
52ee4d0
d3aa856
6392f47
fcd293d
9819399
c75f9f3
b6eda34
62344a9
06d1fe3
03c43df
e97d88d
c7ced6a
66153ad
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18211/18935/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18211/18935/git-merge-result

cmsbuild · 2017-04-05T11:08:23Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

civanch · 2017-04-05T13:24:03Z

@Teemperor , you likely need to rebase

cmsbuild · 2017-04-08T13:39:50Z

Pull request #18211 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

civanch · 2017-04-08T14:40:18Z

please test

cmsbuild · 2017-04-08T14:40:34Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19028/console Started: 2017/04/08 16:41

cmsbuild · 2017-04-08T14:52:00Z

-1

Tested at: 7ce679f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18211/19028/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-07-2300/src/CondTools/SiPixel/test/SiPixelGainCalibrationRejectNoisyAndDead.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-07-2300/src/CondTools/SiPixel/test/SiPixelFakeGenErrorDBSourceReader.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-07-2300/src/CondTools/SiPixel/test/SiPixelCondObjForHLTBuilder.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-07-2300/src/CondTools/SiPixel/test/SiPixelGenErrorDBObjectReader.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-07-2300/src/CondTools/SiPixel/test/SiPixelDynamicInefficiencyReader.cc: In member function 'virtual void SiPixelDynamicInefficiencyReader::analyze(const edm::Event&, const edm::EventSetup&)':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-07-2300/src/CondTools/SiPixel/test/SiPixelDynamicInefficiencyReader.cc:198:25: error: invalid use of incomplete type 'const class TrackerTopology'
     int layerIndex=tTopo->pxbLayer(detid.rawId());
                         ^
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-07-2300/src/CondTools/SiPixel/test/SiPixelDynamicInefficiencyReader.cc:11:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-07-2300/src/DataFormats/SiPixelDetId/interface/PixelBarrelName.h:14:7: note: forward declaration of 'class TrackerTopology'
 class TrackerTopology;

cmsbuild · 2017-04-08T14:52:02Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

These includes cause a layering violation because GeometryCommonDetAlgo in turn already depends on DataFormats/GeometrySurface.

cmsbuild · 2017-04-08T15:05:25Z

Pull request #18211 was updated. @ggovi, @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

civanch · 2017-04-09T15:55:05Z

please test

cmsbuild · 2017-04-09T15:55:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19035/console Started: 2017/04/09 17:57

cmsbuild · 2017-04-09T17:12:03Z

+1
Tested at: 6f44ced
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18211/19035/summary.html

cmsbuild · 2017-04-09T17:12:06Z

Comparison job queued.

cmsbuild · 2017-04-09T18:51:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18211/19035/summary.html

Comparison Summary:

You potentially added 28 lines to the logs
Reco comparison results: 1630 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1917209
DQMHistoTests: Total failures: 38854
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1878182
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

civanch · 2017-04-09T19:58:25Z

+1

cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 5, 2017

cmsbuild added comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels Apr 5, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 5, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Apr 5, 2017

Teemperor force-pushed the TrackerTopology branch from 7f28800 to 7ce679f Compare April 8, 2017 13:39

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Apr 8, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 8, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Apr 8, 2017

Removed #includes to TrackerTopology.h in DataFormats/GeometrySurface

6f44ced

These includes cause a layering violation because GeometryCommonDetAlgo in turn already depends on DataFormats/GeometrySurface.

Teemperor force-pushed the TrackerTopology branch from 7ce679f to 6f44ced Compare April 8, 2017 15:05

cmsbuild added comparison-pending db-pending tests-pending and removed comparison-notrun tests-rejected labels Apr 8, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 9, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 9, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 9, 2017

cmsbuild added simulation-approved and removed simulation-pending labels Apr 9, 2017

davidlange6 merged commit 99423ef into cms-sw:master Apr 10, 2017

Teemperor deleted the TrackerTopology branch December 19, 2017 08:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed #includes to TrackerTopology.h in DataFormats/GeometrySurface #18211

Removed #includes to TrackerTopology.h in DataFormats/GeometrySurface #18211

Teemperor commented Apr 5, 2017

cmsbuild commented Apr 5, 2017

civanch commented Apr 5, 2017

cmsbuild commented Apr 5, 2017 •

edited

cmsbuild commented Apr 5, 2017

cmsbuild commented Apr 5, 2017

civanch commented Apr 5, 2017

cmsbuild commented Apr 8, 2017

civanch commented Apr 8, 2017

cmsbuild commented Apr 8, 2017 •

edited

cmsbuild commented Apr 8, 2017

cmsbuild commented Apr 8, 2017

cmsbuild commented Apr 8, 2017

civanch commented Apr 9, 2017

cmsbuild commented Apr 9, 2017 •

edited

cmsbuild commented Apr 9, 2017

cmsbuild commented Apr 9, 2017

cmsbuild commented Apr 9, 2017

civanch commented Apr 9, 2017

Removed #includes to TrackerTopology.h in DataFormats/GeometrySurface #18211

Removed #includes to TrackerTopology.h in DataFormats/GeometrySurface #18211

Conversation

Teemperor commented Apr 5, 2017

cmsbuild commented Apr 5, 2017

civanch commented Apr 5, 2017

cmsbuild commented Apr 5, 2017 • edited

cmsbuild commented Apr 5, 2017

cmsbuild commented Apr 5, 2017

civanch commented Apr 5, 2017

cmsbuild commented Apr 8, 2017

civanch commented Apr 8, 2017

cmsbuild commented Apr 8, 2017 • edited

cmsbuild commented Apr 8, 2017

cmsbuild commented Apr 8, 2017

cmsbuild commented Apr 8, 2017

civanch commented Apr 9, 2017

cmsbuild commented Apr 9, 2017 • edited

cmsbuild commented Apr 9, 2017

cmsbuild commented Apr 9, 2017

cmsbuild commented Apr 9, 2017

civanch commented Apr 9, 2017

cmsbuild commented Apr 5, 2017 •

edited

cmsbuild commented Apr 8, 2017 •

edited

cmsbuild commented Apr 9, 2017 •

edited