Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register FlatRandomPtAndDxyGunProducer in Sealmodule #18222

Merged
merged 1 commit into from Apr 6, 2017
Merged

Register FlatRandomPtAndDxyGunProducer in Sealmodule #18222

merged 1 commit into from Apr 6, 2017

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Apr 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

IOMC/ParticleGuns

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 5, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18963/console Started: 2017/04/06 07:37

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 5, 2017

bugfix for #17775

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 5, 2017

assign upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18222/18963/summary.html

JR Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • results differ 376 all_mini_OldVSNew_TTbarPUwf50202p0 JR results differ 1232 all_OldVSNew_TTbarPUwf50202p0 SUMMARY Reco comparison results: 1608 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1913169
  • DQMHistoTests: Total failures: 36098
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1876898
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@perrozzi
Copy link
Contributor

perrozzi commented Apr 6, 2017

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 6, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3de20e2 into cms-sw:master Apr 6, 2017
@dildick dildick deleted the from-CMSSW_9_1_X_2017-03-04-1100-displaced-muon-gun branch May 8, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants