Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx74 Correct HGCal Geometry for the last layer of highest ieta of BH #18237

Merged
merged 1 commit into from Apr 7, 2017

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Apr 6, 2017

Overcomes the segmentation fault in validation phase

@bsunanda
Copy link
Contributor Author

bsunanda commented Apr 6, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18969/console Started: 2017/04/06 10:22

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ianna
Copy link
Contributor

ianna commented Apr 6, 2017

@bsunanda - please, provide description

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18237/18969/summary.html

JR Comparison Summary:

  • No significant changes to the logs found
  • results differ 279 all_mini_OldVSNew_TTbar14TeV2023D8wf23234p0 JR results differ 376 all_mini_OldVSNew_TTbarPUwf50202p0 JR results differ 790 all_OldVSNew_TTbar14TeV2023D4wf21234p0 JR results differ 301 all_mini_OldVSNew_TTbar14TeV2023D4wf21234p0 JR results differ 1145 all_OldVSNew_TTbarPUwf50202p0 JR results differ 772 all_OldVSNew_TTbar14TeV2023D8wf23234p0 SUMMARY Reco comparison results: 3663 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1913135
  • DQMHistoTests: Total failures: 50554
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1862408
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@ianna
Copy link
Contributor

ianna commented Apr 6, 2017

assign upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 6, 2017

+1
comparisons show very minor changes in a few quantities for 2023 workflows with HGCal

@ianna
Copy link
Contributor

ianna commented Apr 7, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit 4158421 into cms-sw:master Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants