Activate Max-Sample algorithm in EB by default for 80X legacy re-reco

[emanueledimarco]

This activate the code in PR #17259 for the ECAL barrel by default.
This is the configuration that should be used for the legacy re-reco of 2016 data in 8.0.X.
Activated by default as in suggestion #17259 (comment)

@amassiro @bendavid @paramatti @fcouderc also notice this change.

[cmsbuild]

A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_8_0_X.

It involves the following packages:

RecoLocalCalo/EcalRecProducers

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18975/console Started: 2017/04/06 14:27

[cmsbuild]

+1
Tested at: 25209d4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18240/18975/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18240/18975/summary.html

Comparison Summary:

• No significant changes to the logs found
• results differ 157 all_OldVSNew_RunSinglePh2016Bwf136p731 JR results differ 85 all_mini_OldVSNew_RunSinglePh2016Bwf136p731 SUMMARY Reco comparison results: 242 differences found in the comparisons
• DQMHistoTests: Total files compared: 16
• DQMHistoTests: Total histograms compared: 1164209
• DQMHistoTests: Total failures: 1122
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 1162968
• DQMHistoTests: Total skipped: 118
• DQMHistoTests: Total Missing objects: 0
• Checked 63 log files, 14 edm output root files, 16 DQM output files

[slava77]

+1

for #18240 25209d4

• implemented as described; changes in the default location seem more appropriate and in line with what was done in 9X (the other alternative would be to enable only in Configuration/StandardSequences/python/Reconstruction_Data_cff.py to apply to data only )
• jenkins tests pass and comparisons with baseline show differences only in data workflow with changes starting from a single EB hit energy change which propagates downstream

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1